Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2155063003: MD Settings: more useful bug filing link (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: more useful bug filing link Include normal user-reported bug template and version number in link to file bug in MD Settings appeal banner. Result looks like crbug.com/628951. BUG=none R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4ade10383c3050820b004e325de6f2878db74e4b Cr-Commit-Position: refs/heads/master@{#406073}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
michaelpg
dan plz
4 years, 5 months ago (2016-07-17 23:10:43 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/2155063003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/2155063003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js#newcode49 chrome/browser/resources/settings/settings_ui/settings_ui.js:49: if (version) when do you expect this to ...
4 years, 5 months ago (2016-07-18 04:58:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155063003/1
4 years, 5 months ago (2016-07-18 17:18:25 UTC) #6
michaelpg
https://codereview.chromium.org/2155063003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/2155063003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js#newcode49 chrome/browser/resources/settings/settings_ui/settings_ui.js:49: if (version) On 2016/07/18 04:58:13, Dan Beam wrote: > ...
4 years, 5 months ago (2016-07-18 17:19:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105641)
4 years, 5 months ago (2016-07-18 17:58:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155063003/20001
4 years, 5 months ago (2016-07-18 18:53:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 20:01:06 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:02:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ade10383c3050820b004e325de6f2878db74e4b
Cr-Commit-Position: refs/heads/master@{#406073}

Powered by Google App Engine
This is Rietveld 408576698