Issue 2158533002: [Findit] Use unittest.mock for testing and create a shared method to mock pipeline.

Issue 2158533002: [Findit] Use unittest.mock for testing and create a shared method to mock pipeline. (Closed)

Created:
4 years, 5 months ago by stgao

Modified:
4 years, 5 months ago

Reviewers:
chanli, lijeffrey

CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang, caiw, josiahk

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

[Findit] Use unittest.mock for testing and create a shared method to mock pipeline. BUG= Committed: https://chromium.googlesource.com/infra/infra/+/5338a211644c877d8d1dbce18fda8cbdd11ff082

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -175 lines)			Patch
M	appengine/findit/common/findit_testcase.py	View	1 chunk	+22 lines, -1 line	0 comments	Download
M	appengine/findit/waterfall/analyze_build_failure_pipeline.py	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	appengine/findit/waterfall/build_failure_analysis_pipelines.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py	View	4 chunks	+50 lines, -128 lines	0 comments	Download
M	appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py	View	4 chunks	+10 lines, -31 lines	0 comments	Download
M	appengine/findit/waterfall/test/buildbot_test.py	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

stgao

Hope you guys like this change to make unittest easier with unittest.mock.

4 years, 5 months ago (2016-07-15 20:04:01 UTC) #2

chanli

LGTM. I think the change should make writing unittests much easier!

4 years, 5 months ago (2016-07-15 21:21:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158533002/1

4 years, 5 months ago (2016-07-15 21:56:19 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-15 22:12:14 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/5338a211644c877d8d1dbce18fda8...