appengine/findit/waterfall/build_failure_analysis_pipelines.py - Issue 2158533002: [Findit] Use unittest.mock for testing and create a shared method to mock pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_failure_analysis_pipelines.py

Issue 2158533002: [Findit] Use unittest.mock for testing and create a shared method to mock pipeline. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/analyze_build_failure_pipeline.py ('k') | appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/build_failure_analysis_pipelines.py

diff --git a/appengine/findit/waterfall/build_failure_analysis_pipelines.py b/appengine/findit/waterfall/build_failure_analysis_pipelines.py

index 204cf7cd12d83b204b1e764ce2972d7e5a63c612..81aeed0df0b383446d3024bc1779ee46feff5c4d 100644

--- a/appengine/findit/waterfall/build_failure_analysis_pipelines.py

+++ b/appengine/findit/waterfall/build_failure_analysis_pipelines.py

@@ -11,7 +11,7 @@ from common import appengine_util

from common import constants

from model import analysis_status

from model.wf_analysis import WfAnalysis

-from waterfall import analyze_build_failure_pipeline

+from waterfall.analyze_build_failure_pipeline import AnalyzeBuildFailurePipeline

@ndb.transactional

@@ -101,7 +101,7 @@ def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number,

if NeedANewAnalysis(

master_name, builder_name, build_number, failed_steps,

build_completed, force):

- pipeline_job = analyze_build_failure_pipeline.AnalyzeBuildFailurePipeline(

+ pipeline_job = AnalyzeBuildFailurePipeline(

master_name, builder_name, build_number, build_completed,

force_try_job)

# Explicitly run analysis in the backend module "waterfall-backend".