Don't show [+ ADD CARD] button for merchant that does not take cards.

Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781
Committed: https://crrev.com/4f0ae181161cdec13eb29cc8753aaa83c587a332
Cr-Commit-Position: refs/heads/master@{#406645}

[please use gerrit instead, 2016-07-15 23:56:44]

Description was changed from

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI.

BUG=628781
==========

to

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781
==========

[please use gerrit instead, 2016-07-15 23:58:10]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-07-15 23:58:10]

dfalcantara@, ptal.

[gone, 2016-07-18 17:51:29]

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:74:
public interface SectionDelegate extends View.OnClickListener {
Why remove the static?

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249:
private LinearLayout prepareMainSection(String sectionName) {
Why'd you remove the final?  That's there to prevent subclasses from overriding
this and messing up the layout.  You don't even seem to change its behavior
anywhere.

[please use gerrit instead, 2016-07-18 18:00:15]

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249:
private LinearLayout prepareMainSection(String sectionName) {
On 2016/07/18 17:51:29, dfalcantara wrote:
> Why'd you remove the final?  That's there to prevent subclasses from
overriding
> this and messing up the layout.  You don't even seem to change its behavior
> anywhere.

Warning from AndroidStudio along the lines of "No need for static, because this
function is already private, so subclasses cannot override it."

I am a big fan of reducing technical debt, but there's never time to do it. So
my trick is to reduce technical debt bit-by-bit as I add features and fix bugs.
You could argue that removing "static" here is not technical debt. So I leave
this decision up to you.

[please use gerrit instead, 2016-07-18 18:00:57]

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249:
private LinearLayout prepareMainSection(String sectionName) {
On 2016/07/18 18:00:15, Rouslan (ツ) wrote:
> On 2016/07/18 17:51:29, dfalcantara wrote:
> > Why'd you remove the final?  That's there to prevent subclasses from
> overriding
> > this and messing up the layout.  You don't even seem to change its behavior
> > anywhere.
> 
> Warning from AndroidStudio along the lines of "No need for static, because
this
> function is already private, so subclasses cannot override it."
> 
> I am a big fan of reducing technical debt, but there's never time to do it. So
> my trick is to reduce technical debt bit-by-bit as I add features and fix
bugs.
> You could argue that removing "static" here is not technical debt. So I leave
> this decision up to you.

s/static/final

[gone, 2016-07-18 18:01:39]

lgtm

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249:
private LinearLayout prepareMainSection(String sectionName) {
On 2016/07/18 18:00:57, Rouslan (ツ) wrote:
> On 2016/07/18 18:00:15, Rouslan (ツ) wrote:
> > On 2016/07/18 17:51:29, dfalcantara wrote:
> > > Why'd you remove the final?  That's there to prevent subclasses from
> > overriding
> > > this and messing up the layout.  You don't even seem to change its
behavior
> > > anywhere.
> > 
> > Warning from AndroidStudio along the lines of "No need for static, because
> this
> > function is already private, so subclasses cannot override it."
> > 
> > I am a big fan of reducing technical debt, but there's never time to do it.
So
> > my trick is to reduce technical debt bit-by-bit as I add features and fix
> bugs.
> > You could argue that removing "static" here is not technical debt. So I
leave
> > this decision up to you.
> 
> s/static/final

Acknowledged.

[please use gerrit instead, 2016-07-18 18:12:44]

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:74:
public interface SectionDelegate extends View.OnClickListener {
On 2016/07/18 17:51:28, dfalcantara wrote:
> Why remove the static?

Warning from AndroidStudio "Modifier static is redundant for inner interfaces."

[please use gerrit instead, 2016-07-20 19:08:36]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-07-20 19:08:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2158453003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-20 19:09:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:57:21]

Description was changed from

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781
==========

to

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781
==========

[commit-bot: I haz the power, 2016-07-20 19:57:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 19:58:49]

Description was changed from

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781
==========

to

==========
Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG=628781

Committed: https://crrev.com/4f0ae181161cdec13eb29cc8753aaa83c587a332
Cr-Commit-Position: refs/heads/master@{#406645}
==========

[commit-bot: I haz the power, 2016-07-20 19:58:50]

Patchset 2 (id:??) landed as
https://crrev.com/4f0ae181161cdec13eb29cc8753aaa83c587a332
Cr-Commit-Position: refs/heads/master@{#406645}