Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2158453003: Don't show [+ ADD CARD] button for merchant that does not take cards. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@no-instruments-found
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show [+ ADD CARD] button for merchant that does not take cards. If the merchant does not accept cards as forms of payment, then do not show [+ ADD CARD] button the PaymentRequest UI. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1 BUG=628781 Committed: https://crrev.com/4f0ae181161cdec13eb29cc8753aaa83c587a332 Cr-Commit-Position: refs/heads/master@{#406645}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java View 1 6 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 8 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 5 months ago (2016-07-15 23:58:10 UTC) #3
gone
https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:74: public interface SectionDelegate extends View.OnClickListener { Why remove the ...
4 years, 5 months ago (2016-07-18 17:51:29 UTC) #4
please use gerrit instead
https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java#newcode249 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249: private LinearLayout prepareMainSection(String sectionName) { On 2016/07/18 17:51:29, dfalcantara ...
4 years, 5 months ago (2016-07-18 18:00:15 UTC) #5
please use gerrit instead
https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java#newcode249 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249: private LinearLayout prepareMainSection(String sectionName) { On 2016/07/18 18:00:15, Rouslan ...
4 years, 5 months ago (2016-07-18 18:00:57 UTC) #6
gone
lgtm https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java#newcode249 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:249: private LinearLayout prepareMainSection(String sectionName) { On 2016/07/18 18:00:57, ...
4 years, 5 months ago (2016-07-18 18:01:39 UTC) #7
please use gerrit instead
https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2158453003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:74: public interface SectionDelegate extends View.OnClickListener { On 2016/07/18 17:51:28, ...
4 years, 5 months ago (2016-07-18 18:12:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158453003/20001
4 years, 5 months ago (2016-07-20 19:09:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 19:57:30 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:58:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f0ae181161cdec13eb29cc8753aaa83c587a332
Cr-Commit-Position: refs/heads/master@{#406645}

Powered by Google App Engine
This is Rietveld 408576698