Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4069)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java

Issue 2158453003: Don't show [+ ADD CARD] button for merchant that does not take cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-instruments-found
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
index 57cf28dded6b429baf653f3782ee11962403e7d0..a8a9f336a3eaa0fc629d4a71df1adce697ea30d5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
@@ -71,7 +71,7 @@ public abstract class PaymentRequestSection extends LinearLayout {
public static final String TAG = "PaymentRequestUI";
/** Handles clicks on the widgets and providing data to the PaymentsRequestSection. */
- public static interface SectionDelegate extends View.OnClickListener {
+ public interface SectionDelegate extends View.OnClickListener {
/**
* Called when the user selects a radio button option from an {@link OptionSection}.
*
@@ -249,7 +249,7 @@ public abstract class PaymentRequestSection extends LinearLayout {
*
* @param sectionName Title to display for the section.
*/
- private final LinearLayout prepareMainSection(String sectionName) {
+ private LinearLayout prepareMainSection(String sectionName) {
// The main section is a vertical linear layout that subclasses can append to.
LinearLayout mainSectionLayout = new LinearLayout(getContext());
mainSectionLayout.setOrientation(VERTICAL);
@@ -530,6 +530,7 @@ public abstract class PaymentRequestSection extends LinearLayout {
private static final int INVALID_OPTION_INDEX = -1;
private final List<TextView> mLabelsForTest = new ArrayList<>();
+ private boolean mCanAddItems = true;
/**
* Displays a row representing either a selectable option or some flavor text.
@@ -722,7 +723,7 @@ public abstract class PaymentRequestSection extends LinearLayout {
private final int mVerticalMargin;
/** All the possible PaymentOptions in Layout form, then one row for adding new options. */
- private final ArrayList<OptionRow> mOptionRows = new ArrayList<OptionRow>();
+ private final ArrayList<OptionRow> mOptionRows = new ArrayList<>();
/** Width that the icon takes. */
private final int mIconMaxWidth;
@@ -796,6 +797,11 @@ public abstract class PaymentRequestSection extends LinearLayout {
LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT));
}
+ /** @param canAddItems If false, this section will not show [+ ADD THING] button. */
+ public void setCanAddItems(boolean canAddItems) {
+ mCanAddItems = canAddItems;
+ }
+
/** Updates the View to account for the new {@link SectionInformation} being passed in. */
public void update(SectionInformation information) {
PaymentOption selectedItem = information.getSelectedItem();
@@ -908,7 +914,7 @@ public abstract class PaymentRequestSection extends LinearLayout {
}
// If the user is allowed to add new options, show the button for it.
- if (information.getAddStringId() != 0) {
+ if (information.getAddStringId() != 0 && mCanAddItems) {
OptionRow addRow = new OptionRow(mOptionLayout, mOptionLayout.getChildCount(),
OptionRow.OPTION_ROW_TYPE_ADD, null, false);
addRow.setLabel(information.getAddStringId());

Powered by Google App Engine
This is Rietveld 408576698