Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2158113002: Update interstitials to match the new security indicators (Closed)

Created:
4 years, 5 months ago by felt
Modified:
4 years, 5 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update interstitials to match the new security indicators I've gated this change using the Feature API, behind the feature name SecurityWarningIconUpdate. That way we can monitor the CTR impact and roll back if necessary. Squashed pngs using tools/resources/optimize-png-files.sh -o2. Screenshots on the bug. BUG=629140 Committed: https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a Cr-Commit-Position: refs/heads/master@{#406183}

Patch Set 1 #

Patch Set 2 : Alphabet is hard #

Patch Set 3 : Windows test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/security_interstitials/core/bad_clock_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
A components/security_interstitials/core/browser/resources/images/1x/triangle_red.png View Binary file 0 comments Download
A components/security_interstitials/core/browser/resources/images/1x/triangle_white.png View Binary file 0 comments Download
A components/security_interstitials/core/browser/resources/images/2x/triangle_red.png View Binary file 0 comments Download
A components/security_interstitials/core/browser/resources/images/2x/triangle_white.png View Binary file 0 comments Download
M components/security_interstitials/core/browser/resources/interstitial_v2.css View 1 2 chunks +14 lines, -2 lines 0 comments Download
M components/security_interstitials/core/browser/resources/interstitial_v2.js View 1 chunk +5 lines, -0 lines 0 comments Download
M components/security_interstitials/core/common_string_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/security_interstitials/core/common_string_util.cc View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M components/security_interstitials/core/ssl_error_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
felt
nparker, PTAL?
4 years, 5 months ago (2016-07-18 18:44:00 UTC) #4
Nathan Parker
lgtm It's great that you're doing this as an experiment.
4 years, 5 months ago (2016-07-18 19:47:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158113002/20001
4 years, 5 months ago (2016-07-18 19:56:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/246733)
4 years, 5 months ago (2016-07-18 20:40:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158113002/40001
4 years, 5 months ago (2016-07-19 00:46:07 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 02:04:28 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 02:05:55 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a
Cr-Commit-Position: refs/heads/master@{#406183}

Powered by Google App Engine
This is Rietveld 408576698