Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/security_interstitials/core/common_string_util.cc

Issue 2158113002: Update interstitials to match the new security indicators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Windows test fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/common_string_util.cc
diff --git a/components/security_interstitials/core/common_string_util.cc b/components/security_interstitials/core/common_string_util.cc
index 2cb0375d0d08e0a84ffcd08f0631a353f08a6d67..c5f01ea9669ac3c591fdd0feecaee935998c6ab8 100644
--- a/components/security_interstitials/core/common_string_util.cc
+++ b/components/security_interstitials/core/common_string_util.cc
@@ -4,6 +4,7 @@
#include "components/security_interstitials/core/common_string_util.h"
+#include "base/feature_list.h"
#include "base/i18n/rtl.h"
#include "base/i18n/time_formatting.h"
#include "base/strings/string_util.h"
@@ -12,6 +13,11 @@
#include "net/base/net_errors.h"
#include "ui/base/l10n/l10n_util.h"
+namespace {
+ const base::Feature kSecurityWarningIconUpdate{
+ "SecurityWarningIconUpdate", base::FEATURE_DISABLED_BY_DEFAULT};
+} // namespace
+
namespace security_interstitials {
namespace common_string_util {
@@ -50,6 +56,11 @@ void PopulateSSLDebuggingStrings(const net::SSLInfo ssl_info,
"pem", base::JoinString(encoded_chain, base::StringPiece()));
}
+void PopulateNewIconStrings(base::DictionaryValue* load_time_data) {
+ load_time_data->SetBoolean(
+ "iconUpdate", base::FeatureList::IsEnabled(kSecurityWarningIconUpdate));
+}
+
} // namespace common_string_util
} // namespace security_interstitials
« no previous file with comments | « components/security_interstitials/core/common_string_util.h ('k') | components/security_interstitials/core/ssl_error_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698