cc: Remove retro frame logic from scheduler.

cc: Remove retro frame logic from scheduler.

The retro frame logic is overly complex and has surprising behavior such
as converting begin frames into PostTasks. This has been replaced with
a simpler callback that's only used for MISSED begin frames.

R=brianderson@chromium.org
BUG=602485
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

[sunnyps, 2016-07-18 22:57:49]

Description was changed from

==========
cc: Remove retro frame logic from scheduler.

The retro frame logic is overly complex and has surprising behavior such
as converting begin frames into PostTasks. This has been replaced with
a simpler callback that's only used for MISSED begin frames.

R=brianderson@chromium.org
BUG=602485
==========

to

==========
cc: Remove retro frame logic from scheduler.

The retro frame logic is overly complex and has surprising behavior such
as converting begin frames into PostTasks. This has been replaced with
a simpler callback that's only used for MISSED begin frames.

R=brianderson@chromium.org
BUG=602485
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[sunnyps, 2016-07-18 22:57:52]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[sunnyps, 2016-07-18 22:58:15]

PTAL :)

[commit-bot: I haz the power, 2016-07-18 22:58:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:20:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:20:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[brianderson, 2016-07-20 00:35:13]

Didn't get to look at the tests yet, but the logic is looking good. Just had one
question. Will take a look at the tests tomorrow.

https://codereview.chromium.org/2158023005/diff/1/cc/scheduler/scheduler_stat...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/2158023005/diff/1/cc/scheduler/scheduler_stat...
cc/scheduler/scheduler_state_machine.cc:363: if (wait_for_ready_to_draw_)
Does this help avoid drawing in the deadline in the Browser now that a
BeginFrame can come in?
Do we still draw as soon as we get NotifyReadyToDraw?

[brianderson, 2016-07-20 17:12:20]

Looks like some of the trybots hit a dcheck:

  [517:517:0718/161836:FATAL:begin_frame_tracker.cc(33)] Check failed:
current_args_.frame_time <= new_args.frame_time (139745318857254
bogo-microseconds vs. 6384277952 bogo-microseconds)
  #0 0x7f18fb4c59de base::debug::StackTrace::StackTrace()
  #1 0x7f18fb4dd85b logging::LogMessage::~LogMessage()
  #2 0x7f18fc3313e6 cc::BeginFrameTracker::Start()
  #3 0x7f18fc3380d6 cc::Scheduler::BeginImplFrame()
  #4 0x7f18fc3379a9 cc::Scheduler::BeginImplFrameWithDeadline()
  #5 0x7f18fc3372f3 cc::Scheduler::OnBeginFrameDerivedImpl()
  #6 0x7f18fc280c9d cc::BeginFrameObserverBase::OnBeginFrame()
  #7 0x7f18fc281cfb cc::DelayBasedBeginFrameSource::OnTimerTick()
  #8 0x7f18fc282309 cc::DelayBasedTimeSource::OnTimerTick()
  #9 0x7f18fb555199 base::debug::TaskAnnotator::RunTask()
  #10 0x7f18fb4e4f95 base::MessageLoop::RunTask()
  #11 0x7f18fb4e52a8 base::MessageLoop::DeferOrRunPendingTask()
  #12 0x7f18fb4e57de base::MessageLoop::DoDelayedWork()
  #13 0x7f18fb4e70e7 base::MessagePumpGlib::Run()
  #14 0x7f18fb4e4a91 base::MessageLoop::RunHandler()
  #15 0x7f18fb507bc0 base::RunLoop::Run()
  #16 0x7f18fb3a6eaa ChromeBrowserMainParts::MainMessageLoopRun()
  #17 0x7f18f8d7b499 content::BrowserMainLoop::RunMainMessageLoopParts()
  #18 0x7f18f8d7e758 content::BrowserMainRunnerImpl::Run()
  #19 0x7f18f8d76fac content::BrowserMain()
  #20 0x7f18fb103b2b content::RunNamedProcessTypeMain()
  #21 0x7f18fb1045a3 content::ContentMainRunnerImpl::Run()
  #22 0x7f18fb102e70 content::ContentMain()
  #23 0x7f18f87258bb ChromeMain
  #24 0x7f18f17717ed __libc_start_main
  #25 0x7f18f872578d <unknown>

[sunnyps, 2017-03-01 23:45:00]

Description was changed from

==========
cc: Remove retro frame logic from scheduler.

The retro frame logic is overly complex and has surprising behavior such
as converting begin frames into PostTasks. This has been replaced with
a simpler callback that's only used for MISSED begin frames.

R=brianderson@chromium.org
BUG=602485
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove retro frame logic from scheduler.

The retro frame logic is overly complex and has surprising behavior such
as converting begin frames into PostTasks. This has been replaced with
a simpler callback that's only used for MISSED begin frames.

R=brianderson@chromium.org
BUG=602485
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========