Issue 2157993003: Fixed regression bug regarding pod on public session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2157993003: Fixed regression bug regarding pod on public session. (Closed)

Created:
4 years, 5 months ago by jdufault

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed regression bug regarding pod on public session. Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered. BUG=626157 Review-Url: https://codereview.chromium.org/2130143002 Cr-Commit-Position: refs/heads/master@{#404482} (cherry picked from commit 57237df88100d360800e6131cce2434642071023)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -6 lines)			Patch
	M	ui/login/account_picker/user_pod_row.css	View		4 chunks	+25 lines, -4 lines	0 comments	Download
	M	ui/login/account_picker/user_pod_row.js	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jdufault

4 years, 5 months ago (2016-07-21 19:47:13 UTC) #1

Description was changed from

==========
Fixed regression bug regarding pod on public session.

Bug was caused by having transitions for the image and sign in indicator for the
user pod, while the image pane stays 100%. So when we are in the public account
user pod the image will be centered.

BUG=626157

Review-Url: https://codereview.chromium.org/2130143002
Cr-Commit-Position: refs/heads/master@{#404482}
(cherry picked from commit 57237df88100d360800e6131cce2434642071023)
==========

to

==========
Fixed regression bug regarding pod on public session.

Bug was caused by having transitions for the image and sign in indicator for the
user pod, while the image pane stays 100%. So when we are in the public account
user pod the image will be centered.

BUG=626157

Review-Url: https://codereview.chromium.org/2130143002
Cr-Commit-Position: refs/heads/master@{#404482}
(cherry picked from commit 57237df88100d360800e6131cce2434642071023)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages