Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2130143002: Fixed regression bug regarding pod on public session. (Closed)

Created:
4 years, 5 months ago by sammiequon
Modified:
4 years, 5 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed regression bug regarding pod on public session. Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered. BUG=626157 Committed: https://crrev.com/57237df88100d360800e6131cce2434642071023 Cr-Commit-Position: refs/heads/master@{#404482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M ui/login/account_picker/user_pod_row.css View 5 chunks +25 lines, -5 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sammiequon
jdufault@, xiyuan@ - Please take a look.
4 years, 5 months ago (2016-07-07 23:36:42 UTC) #3
sammiequon
4 years, 5 months ago (2016-07-08 00:17:21 UTC) #5
xiyuan
lgtm
4 years, 5 months ago (2016-07-08 16:02:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130143002/1
4 years, 5 months ago (2016-07-08 20:00:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 20:42:03 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 20:42:15 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 20:44:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57237df88100d360800e6131cce2434642071023
Cr-Commit-Position: refs/heads/master@{#404482}

Powered by Google App Engine
This is Rietveld 408576698