Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 68daf9833cc79d4c7ce719034065fb3b6fe390a8..4553c1dd4f2eac5ac6b6505929b55eef6965af10 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -208,6 +208,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
// SiteInstanceImpl::Observer
void RenderProcessGone(SiteInstanceImpl* site_instance) override;
+ void RequestTextSurroundingSelection(
no sievers 2016/07/20 21:14:32 Can you move this up into the block '// RenderFram
AKV 2016/07/21 09:13:52 Done.
+ const TextSurroundingSelectionCallback& callback,
+ int max_length) override;
+
// Creates a RenderFrame in the renderer process.
bool CreateRenderFrame(int proxy_routing_id,
int opener_routing_id,
@@ -1042,6 +1046,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
mojo::Binding<mojom::FrameHost> frame_host_binding_;
mojom::FramePtr frame_;
+ // Callback for responding when
+ // |FrameHostMsg_TextSurroundingSelectionResponse| message comes.
+ TextSurroundingSelectionCallback text_surrounding_selection_callback_;
+
// NOTE: This must be the last member.
base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698