Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 SiteInstance* AccessibilityGetSiteInstance() override; 201 SiteInstance* AccessibilityGetSiteInstance() override;
202 void AccessibilityHitTest(const gfx::Point& point) override; 202 void AccessibilityHitTest(const gfx::Point& point) override;
203 void AccessibilitySetAccessibilityFocus(int acc_obj_id) override; 203 void AccessibilitySetAccessibilityFocus(int acc_obj_id) override;
204 void AccessibilityFatalError() override; 204 void AccessibilityFatalError() override;
205 gfx::AcceleratedWidget AccessibilityGetAcceleratedWidget() override; 205 gfx::AcceleratedWidget AccessibilityGetAcceleratedWidget() override;
206 gfx::NativeViewAccessible AccessibilityGetNativeViewAccessible() override; 206 gfx::NativeViewAccessible AccessibilityGetNativeViewAccessible() override;
207 207
208 // SiteInstanceImpl::Observer 208 // SiteInstanceImpl::Observer
209 void RenderProcessGone(SiteInstanceImpl* site_instance) override; 209 void RenderProcessGone(SiteInstanceImpl* site_instance) override;
210 210
211 void RequestTextSurroundingSelection(
no sievers 2016/07/20 21:14:32 Can you move this up into the block '// RenderFram
AKV 2016/07/21 09:13:52 Done.
212 const TextSurroundingSelectionCallback& callback,
213 int max_length) override;
214
211 // Creates a RenderFrame in the renderer process. 215 // Creates a RenderFrame in the renderer process.
212 bool CreateRenderFrame(int proxy_routing_id, 216 bool CreateRenderFrame(int proxy_routing_id,
213 int opener_routing_id, 217 int opener_routing_id,
214 int parent_routing_id, 218 int parent_routing_id,
215 int previous_sibling_routing_id); 219 int previous_sibling_routing_id);
216 220
217 // Tracks whether the RenderFrame for this RenderFrameHost has been created in 221 // Tracks whether the RenderFrame for this RenderFrameHost has been created in
218 // the renderer process. This is currently only used for subframes. 222 // the renderer process. This is currently only used for subframes.
219 // TODO(creis): Use this for main frames as well when RVH goes away. 223 // TODO(creis): Use this for main frames as well when RVH goes away.
220 void SetRenderFrameCreated(bool created); 224 void SetRenderFrameCreated(bool created);
(...skipping 814 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 bool should_reuse_web_ui_; 1039 bool should_reuse_web_ui_;
1036 1040
1037 // PlzNavigate: The LoFi state of the last navigation. This is used during 1041 // PlzNavigate: The LoFi state of the last navigation. This is used during
1038 // history navigation of subframes to ensure that subframes navigate with the 1042 // history navigation of subframes to ensure that subframes navigate with the
1039 // same LoFi status as the top-level frame. 1043 // same LoFi status as the top-level frame.
1040 LoFiState last_navigation_lofi_state_; 1044 LoFiState last_navigation_lofi_state_;
1041 1045
1042 mojo::Binding<mojom::FrameHost> frame_host_binding_; 1046 mojo::Binding<mojom::FrameHost> frame_host_binding_;
1043 mojom::FramePtr frame_; 1047 mojom::FramePtr frame_;
1044 1048
1049 // Callback for responding when
1050 // |FrameHostMsg_TextSurroundingSelectionResponse| message comes.
1051 TextSurroundingSelectionCallback text_surrounding_selection_callback_;
1052
1045 // NOTE: This must be the last member. 1053 // NOTE: This must be the last member.
1046 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1054 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1047 1055
1048 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1056 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1049 }; 1057 };
1050 1058
1051 } // namespace content 1059 } // namespace content
1052 1060
1053 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1061 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698