Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection (Closed)

Created:
4 years, 5 months ago by AKV
Modified:
4 years, 5 months ago
Reviewers:
Ted C, no sievers
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContentViewCore::RequestTextSurroundingSelection This change takes care of scaling down the scope of CVC by removing RequestTextSurroundingSelection() method. Logic has been moved to RenderFrameHost. Additionally added the support of responding with empty text when a new request comes during processing of a pending request. BUG=626770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/deb84849f66aa9db12a4c4bd8eb0bb3e18fd441d Cr-Commit-Position: refs/heads/master@{#406812}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the review comments. #

Total comments: 6

Patch Set 3 : Fixed the review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -88 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 1 chunk +20 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/android/content_view_core.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
AKV
PTAL!
4 years, 5 months ago (2016-07-16 15:06:29 UTC) #3
no sievers
thanks! just one nit. https://codereview.chromium.org/2157793002/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc File chrome/browser/android/contextualsearch/contextual_search_delegate.cc (right): https://codereview.chromium.org/2157793002/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc#newcode247 chrome/browser/android/contextualsearch/contextual_search_delegate.cc:247: if (!focused_frame || focused_frame->HasTextSurroundingSelectionCallback()) { ...
4 years, 5 months ago (2016-07-18 22:41:18 UTC) #4
AKV
PTAL! https://codereview.chromium.org/2157793002/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc File chrome/browser/android/contextualsearch/contextual_search_delegate.cc (right): https://codereview.chromium.org/2157793002/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc#newcode247 chrome/browser/android/contextualsearch/contextual_search_delegate.cc:247: if (!focused_frame || focused_frame->HasTextSurroundingSelectionCallback()) { On 2016/07/18 22:41:18, ...
4 years, 5 months ago (2016-07-20 12:32:08 UTC) #5
no sievers
lgtm, thanks. https://codereview.chromium.org/2157793002/diff/20001/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/2157793002/diff/20001/content/browser/frame_host/render_frame_host_impl.cc#newcode1578 content/browser/frame_host/render_frame_host_impl.cc:1578: DCHECK(!callback.is_null()); nit: move the DCHECK() to the ...
4 years, 5 months ago (2016-07-20 21:14:32 UTC) #6
AKV
@sievers - Thank you for reviewing. I will address the nits in next patch set. ...
4 years, 5 months ago (2016-07-20 21:54:45 UTC) #8
Ted C
lgtm w/ nit https://codereview.chromium.org/2157793002/diff/20001/chrome/browser/android/contextualsearch/contextual_search_delegate.cc File chrome/browser/android/contextualsearch/contextual_search_delegate.cc (right): https://codereview.chromium.org/2157793002/diff/20001/chrome/browser/android/contextualsearch/contextual_search_delegate.cc#newcode239 chrome/browser/android/contextualsearch/contextual_search_delegate.cc:239: DCHECK(content_view_core && content_view_core->GetWebContents()); this seems unneeded ...
4 years, 5 months ago (2016-07-20 22:23:29 UTC) #9
AKV
Thank you Ted and Sievers for your reviews. I have incorporated the changes now. https://codereview.chromium.org/2157793002/diff/20001/chrome/browser/android/contextualsearch/contextual_search_delegate.cc ...
4 years, 5 months ago (2016-07-21 09:13:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157793002/40001
4 years, 5 months ago (2016-07-21 09:18:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 10:24:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 10:27:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/deb84849f66aa9db12a4c4bd8eb0bb3e18fd441d
Cr-Commit-Position: refs/heads/master@{#406812}

Powered by Google App Engine
This is Rietveld 408576698