Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2157733002: Delete the v8_target_cpu/v8_current_cpu hack in the GN build. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the v8_target_cpu/v8_current_cpu hack in the GN build. This finishes the work in bug 625353 to make v8_target_cpu/v8_current_cpu work correctly across multiple toolchains, by deleting the workaround that was needed to get the changes to land across repos. TBR=machenbach@chromium.org BUG=625353 Committed: https://crrev.com/d3e00ac37e3722cc93d102164b23629e8cc6af31 Cr-Commit-Position: refs/heads/master@{#405933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-16 03:20:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157733002/1
4 years, 5 months ago (2016-07-16 03:21:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-16 04:28:42 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3e00ac37e3722cc93d102164b23629e8cc6af31 Cr-Commit-Position: refs/heads/master@{#405933}
4 years, 5 months ago (2016-07-16 04:29:55 UTC) #6
Michael Achenbach
4 years, 5 months ago (2016-07-18 07:02:52 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698