build/toolchain/gcc_toolchain.gni - Issue 2157733002: Delete the v8_target_cpu/v8_current_cpu hack in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2157733002: Delete the v8_target_cpu/v8_current_cpu hack in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index 5ecabe5cdcef1cc7278d6bfe92d18203b23d2583..94aac5bdc2fffde408e73de7329717f0f295cf4f 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -475,12 +475,6 @@ template("gcc_toolchain") {

v8_current_cpu = current_cpu

}

- # TODO(crbug.com/625353) - Delete after v8 has been updated

- # to only refer to v8_current_cpu. Until then, we need to make

- # sure that v8_current_cpu always has the same value as v8_target_cpu,

- # so that //build defines evaluate the way v8 is expecting them to.

- v8_current_cpu = v8_target_cpu

# Disable sanitizers for non-default toolchains.

is_asan = false

is_cfi = false

« no previous file with comments | « no previous file | no next file » | no next file with comments »