[Mac/GN] Add a new linker_driver.py option to save unstripped linker output.

build/config/mac/symbols.gni

Index: build/config/mac/symbols.gni
diff --git a/build/config/mac/symbols.gni b/build/config/mac/symbols.gni
index 9574e1d16c87fe20f3764bb775b7aabb1665104c..0c64df007883351a889ef062a27ca6bb471fc441 100644
--- a/build/config/mac/symbols.gni
+++ b/build/config/mac/symbols.gni
@@ -21,4 +21,13 @@ declare_args() {
   # linked target and apply custom -Wcrl,strip flags. See
   # //build/toolchain/mac/linker_driver.py for more information.
   enable_stripping = is_official_build
+
+  # If enable_stripping=true, setting this to true will save an unstripped

[Mark Mentovai, 2016/07/15 19:24:17]

This leads with the less important thing and buries the important thing. I’d
reword this to say “Setting this to true will…. Unstripped copies can be useful
when enable_stripping is true.”

[Robert Sesek, 2016/07/15 20:50:22]

Reworded to be in the same style as other args.

+  # copy of build products with an ".unstripped" suffix.
+  save_unstripped_output = false
+}
+
+if (save_unstripped_output) {
+  assert(enable_stripping,
+         "save_unstripped_output=true requires enable_stripping=true")

[Mark Mentovai, 2016/07/15 19:24:17]

meh.

[Robert Sesek, 2016/07/15 20:50:22]

I think restricting the number of odd configurations is desirable.

 }