[Mac/GN] Add a new linker_driver.py option to save unstripped linker output.

build/config/mac/symbols.gni

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 
 # This file declares arguments and configs that control whether dSYM debug
 # info is produced and whether build products are stripped.
 
 declare_args() {
   # Produce dSYM files for targets that are configured to do so. dSYM
   # generation is controlled globally as it is a linker output (produced via
   # the //build/toolchain/mac/linker_driver.py. Enabling this will result in
   # all shared library, loadable module, and executable targets having a dSYM
   # generated.
   enable_dsyms = is_official_build
 
   # Strip symbols from linked targets by default. If this is enabled, the
   # //build/config/mac:strip_all config will be applied to all linked targets.
   # If custom stripping paramters are required, remove that config from a
   # linked target and apply custom -Wcrl,strip flags. See
   # //build/toolchain/mac/linker_driver.py for more information.
   enable_stripping = is_official_build
+
+  # If enable_stripping=true, setting this to true will save an unstripped

[Mark Mentovai, 2016/07/15 19:24:17]

This leads with the less important thing and buries the important thing. I’d
reword this to say “Setting this to true will…. Unstripped copies can be useful
when enable_stripping is true.”

[Robert Sesek, 2016/07/15 20:50:22]

Reworded to be in the same style as other args.

+  # copy of build products with an ".unstripped" suffix.
+  save_unstripped_output = false
 }
+
+if (save_unstripped_output) {
+  assert(enable_stripping,
+         "save_unstripped_output=true requires enable_stripping=true")

[Mark Mentovai, 2016/07/15 19:24:17]

meh.

[Robert Sesek, 2016/07/15 20:50:22]

I think restricting the number of odd configurations is desirable.

+}