Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: build/config/mac/BUILD.gn

Issue 2157573002: [Mac/GN] Add a new linker_driver.py option to save unstripped linker output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/mac/BUILD.gn
diff --git a/build/config/mac/BUILD.gn b/build/config/mac/BUILD.gn
index d49db4383625bb254a07fcca49377c13ce8f2b55..074606c55998368360de6d6142ebbfb33ea15363 100644
--- a/build/config/mac/BUILD.gn
+++ b/build/config/mac/BUILD.gn
@@ -96,8 +96,8 @@ config("mac_executable_flags") {
ldflags = [ "-Wl,-pie" ] # Position independent.
}
-# The ldflags referenced below are handled by
-# //build/toolchain/mac/linker_driver.py.
+# The ldflags referenced below are handled by //build/toolchain/mac/linker_driver.py.
Mark Mentovai 2016/07/15 19:24:17 This was wrapped before, why not now?
Robert Sesek 2016/07/15 20:50:22 Don't know what happened, but fixed.
+
# Remove this config if a target wishes to change the arguments passed to the
# strip command during linking. This config by default strips all symbols
# from a binary, but some targets may wish to specify a saves file to preserve
@@ -107,3 +107,10 @@ config("strip_all") {
ldflags = [ "-Wcrl,strip,-x,-S" ]
}
}
+
+# This config will keep unstripped copies of the linker output.
+config("save_unstripped_output") {
+ if (save_unstripped_output) {
+ ldflags = [ "-Wcrl,unstripped," + rebase_path(root_out_dir) ]
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698