Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2157513002:
Add copy (when needed) to SkGpuDevice::asSpecial (Closed)
|
Created:
4 years, 5 months ago by robertphillips Modified:
4 years, 5 months ago Reviewers:
bsalomon CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd copy (when needed) to SkGpuDevice::asSpecial
split out of https://codereview.chromium.org/2145343005/ (Recast draw_filter_into_device as drawDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002
Committed: https://skia.googlesource.com/skia/+/04d62182fe66c55d3b3e4c44e8caf0bd5f2ea111
Patch Set 1 #Patch Set 2 : Add copy (when needed) to SkGpuDevice::asSpecial #
Messages
Total messages: 21 (17 generated)
Description was changed from ========== Add copy (when needed) to SkGpuDevice::asSpecial ========== to ========== Add copy (when needed) to SkGpuDevice::asSpecial GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002 ==========
Description was changed from ========== Add copy (when needed) to SkGpuDevice::asSpecial GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002 ========== to ========== Add copy (when needed) to SkGpuDevice::asSpecial split out of https://codereview.chromium.org/2145343005/ (Recast draw_filter_into_device as drawDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002 ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add copy (when needed) to SkGpuDevice::asSpecial split out of https://codereview.chromium.org/2145343005/ (Recast draw_filter_into_device as drawDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002 ========== to ========== Add copy (when needed) to SkGpuDevice::asSpecial split out of https://codereview.chromium.org/2145343005/ (Recast draw_filter_into_device as drawDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157513002 Committed: https://skia.googlesource.com/skia/+/04d62182fe66c55d3b3e4c44e8caf0bd5f2ea111 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/04d62182fe66c55d3b3e4c44e8caf0bd5f2ea111 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
