Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2157453002: Do FilteringNetworkManager::CheckPermission from new Initialize method. (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Do FilteringNetworkManager::CheckPermission from new Initialize method. This is guaranteed to be called from PeerConnection on the correct thread when the PeerConnection is initializing. This means it's no longer PeerConnectionDependencyFactory's responsibility to initialize it, and it can be initialized in a thread safe way. BUG=617648 Review-Url: https://codereview.chromium.org/2113523003 Cr-Commit-Position: refs/heads/master@{#404395} (cherry picked from commit c6dcde40c5dc3ad78ee039f6a7e9e71437256512) Committed: https://chromium.googlesource.com/chromium/src/+/f5a188d3a5f73412355e523c9c6b1a39eae2a9b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
4 years, 5 months ago (2016-07-15 10:50:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5a188d3a5f73412355e523c9c6b1a39eae2a9b2.

Powered by Google App Engine
This is Rietveld 408576698