content/renderer/p2p/filtering_network_manager.h - Issue 2157453002: Do FilteringNetworkManager::CheckPermission from new Initialize method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/filtering_network_manager.h

Issue 2157453002: Do FilteringNetworkManager::CheckPermission from new Initialize method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('k') | content/renderer/p2p/filtering_network_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/p2p/filtering_network_manager.h

diff --git a/content/renderer/p2p/filtering_network_manager.h b/content/renderer/p2p/filtering_network_manager.h

index 59e2242fcfb5c29c2f965489a34476f47359f776..01b0ccd24423ba68f665561be7c5dfbcdd92a976 100644

--- a/content/renderer/p2p/filtering_network_manager.h

+++ b/content/renderer/p2p/filtering_network_manager.h

@@ -46,11 +46,8 @@ class FilteringNetworkManager : public rtc::NetworkManagerBase,

CONTENT_EXPORT ~FilteringNetworkManager() override;

- // Check mic/camera permission.

- // This is called by PeerConnectionDependencyFactory.

- CONTENT_EXPORT void CheckPermission();

// rtc::NetworkManager:

+ void Initialize() override;

void StartUpdating() override;

void StopUpdating() override;

void GetNetworks(NetworkList* networks) const override;

@@ -58,6 +55,9 @@ class FilteringNetworkManager : public rtc::NetworkManagerBase,

rtc::IPAddress* ipaddress) const override;

private:

+ // Check mic/camera permission.

+ void CheckPermission();

// Receive callback from MediaPermission when the permission status is

// available.

void OnPermissionStatus(bool granted);