Moves WindowCycleList/Controller to ash/common

Moves WindowCycleList/Controller to ash/common

BUG=582590, 629497
TEST=covered by tests
R=estade@chromium.org, jamescook@chromium.org

Committed: https://crrev.com/37f0dd1f6a3631a8d320f5dec3dc1111f94f640c
Cr-Commit-Position: refs/heads/master@{#406310}

[sky, 2016-07-19 13:35:01]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:49:45]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[James Cook, 2016-07-19 15:42:21]

LGTM

https://codereview.chromium.org/2157393002/diff/1/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2157393002/diff/1/ash/common/wm_shell.cc#newc...
ash/common/wm_shell.cc:145: window_cycle_controller_.reset(new
WindowCycleController());
It doesn't look like WindowCycleController does any interesting work in its
constructor and doesn't have any interesting member variables. Could it be
created in the WmShell constructor?

[sky, 2016-07-19 17:05:18]

https://codereview.chromium.org/2157393002/diff/1/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2157393002/diff/1/ash/common/wm_shell.cc#newc...
ash/common/wm_shell.cc:145: window_cycle_controller_.reset(new
WindowCycleController());
On 2016/07/19 15:42:21, James Cook wrote:
> It doesn't look like WindowCycleController does any interesting work in its
> constructor and doesn't have any interesting member variables. Could it be
> created in the WmShell constructor?

Creation can happen at any time, but destruction depends upon
mru_window_tracker, so that has to be explicit. Updated.

[sky, 2016-07-19 17:05:51]

I'm going to land this. Evan, I added you mostly so you know where your code
moved to.

[sky, 2016-07-19 17:05:56]

The CQ bit was checked by sky@chromium.org

[sky, 2016-07-19 17:05:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2157393002/#ps20001
(title: "Feedback and std::move")

[commit-bot: I haz the power, 2016-07-19 17:06:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-07-19 17:50:39]

On 2016/07/19 17:05:51, sky wrote:
> I'm going to land this. Evan, I added you mostly so you know where your code
> moved to.

I figured as much. Thanks for the heads up.

[commit-bot: I haz the power, 2016-07-19 18:01:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 18:03:23]

Description was changed from

==========
Moves WindowCycleList/Controller to ash/common

BUG=582590,629497
TEST=covered by tests
R=estade@chromium.org, jamescook@chromium.org
==========

to

==========
Moves WindowCycleList/Controller to ash/common

BUG=582590,629497
TEST=covered by tests
R=estade@chromium.org, jamescook@chromium.org

Committed: https://crrev.com/37f0dd1f6a3631a8d320f5dec3dc1111f94f640c
Cr-Commit-Position: refs/heads/master@{#406310}
==========

[commit-bot: I haz the power, 2016-07-19 18:03:24]

Patchset 2 (id:??) landed as
https://crrev.com/37f0dd1f6a3631a8d320f5dec3dc1111f94f640c
Cr-Commit-Position: refs/heads/master@{#406310}