Moves WindowCycleList/Controller to ash/common

ash/common/wm_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm_shell.h"
 
 #include <utility>
 
 #include "ash/common/accessibility_delegate.h"
 #include "ash/common/focus_cycler.h"
 #include "ash/common/keyboard/keyboard_ui.h"
 #include "ash/common/shell_delegate.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/system/brightness_control_delegate.h"
 #include "ash/common/system/keyboard_brightness_control_delegate.h"
 #include "ash/common/system/tray/system_tray_delegate.h"
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
 #include "ash/common/wm/mru_window_tracker.h"
 #include "ash/common/wm/overview/window_selector_controller.h"
+#include "ash/common/wm/window_cycle_controller.h"
 #include "ash/common/wm_window.h"
 #include "base/bind.h"
 #include "base/logging.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/common/system/chromeos/brightness/brightness_controller_chromeos.h"
 #include "ash/common/system/chromeos/keyboard_brightness_controller.h"
 #include "ash/common/system/chromeos/session/logout_confirmation_controller.h"
 #endif
 
@@ skipping 102 matching lines @@
 }
 
 void WmShell::DeleteSystemTrayDelegate() {
   DCHECK(system_tray_delegate_);
 #if defined(OS_CHROMEOS)
   logout_confirmation_controller_.reset();
 #endif
   system_tray_delegate_.reset();
 }
 
+void WmShell::CreateWindowCycleController() {
+  window_cycle_controller_.reset(new WindowCycleController());

[James Cook, 2016/07/19 15:42:21]

It doesn't look like WindowCycleController does any interesting work in its
constructor and doesn't have any interesting member variables. Could it be
created in the WmShell constructor?

[sky, 2016/07/19 17:05:18]

Creation can happen at any time, but destruction depends upon
mru_window_tracker, so that has to be explicit. Updated.

+}
+
+void WmShell::DeleteWindowCycleController() {
+  window_cycle_controller_.reset();
+}
+
 void WmShell::DeleteWindowSelectorController() {
   window_selector_controller_.reset();
 }
 
 void WmShell::CreateMaximizeModeController() {
   maximize_mode_controller_.reset(new MaximizeModeController);
 }
 
 void WmShell::DeleteMaximizeModeController() {
   maximize_mode_controller_.reset();
 }
 
 void WmShell::CreateMruWindowTracker() {
   mru_window_tracker_.reset(new MruWindowTracker);
 }
 
 void WmShell::DeleteMruWindowTracker() {
   mru_window_tracker_.reset();
 }
 
 }  // namespace ash