DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.

third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 134 matching lines @@
         this._innerSetSidebarSizeDIP(this._preferredSidebarSizeDIP(), !!animate);
     },
 
     /**
      * @param {!WebInspector.Widget} widget
      */
     setMainWidget: function(widget)
     {
         if (this._mainWidget === widget)
             return;
+        this.suspendInvalidations();
         if (this._mainWidget)
             this._mainWidget.detach();
         this._mainWidget = widget;
         if (widget) {
             widget.element.classList.add("insertion-point-main");
             widget.element.classList.remove("insertion-point-sidebar");
+            widget.attach(this.element, this._sidebarWidget ? this._sidebarWidget.element : null);
             if (this._showMode === WebInspector.SplitWidget.ShowMode.OnlyMain || this._showMode === WebInspector.SplitWidget.ShowMode.Both)
-                widget.show(this.element);
+                widget.showWidget();
         }
+        this.resumeInvalidations();
     },
 
     /**
      * @param {!WebInspector.Widget} widget
      */
     setSidebarWidget: function(widget)
     {
         if (this._sidebarWidget === widget)
             return;
+        this.suspendInvalidations();
         if (this._sidebarWidget)
             this._sidebarWidget.detach();
         this._sidebarWidget = widget;
         if (widget) {
             widget.element.classList.add("insertion-point-sidebar");
             widget.element.classList.remove("insertion-point-main");
+            widget.attach(this.element);
             if (this._showMode === WebInspector.SplitWidget.ShowMode.OnlySidebar || this._showMode === WebInspector.SplitWidget.ShowMode.Both)
-                widget.show(this.element);
+                widget.showWidget();
         }
+        this.resumeInvalidations();
     },
 
     /**
      * @return {?WebInspector.Widget}
      */
     mainWidget: function()
     {
         return this._mainWidget;
     },
 
     /**
      * @return {?WebInspector.Widget}
      */
     sidebarWidget: function()
     {
         return this._sidebarWidget;
     },
 
     /**
      * @override
      * @param {!WebInspector.Widget} widget
      */
     childWasDetached: function(widget)
     {
-        if (this._detaching)
-            return;
         if (this._mainWidget === widget)
             delete this._mainWidget;
         if (this._sidebarWidget === widget)
             delete this._sidebarWidget;
     },
 
     /**
      * @return {boolean}
      */
     isSidebarSecond: function()
@@ skipping 91 matching lines @@
         this._cancelAnimation();
 
         /**
          * @this {WebInspector.SplitWidget}
          */
         function callback()
         {
             if (sideToShow) {
                 // Make sure main is first in the children list.
                 if (sideToShow === this._mainWidget)
-                    this._mainWidget.show(this.element, this._sidebarWidget ? this._sidebarWidget.element : null);
+                    this._mainWidget.showWidget();
                 else
-                    this._sidebarWidget.show(this.element);
+                    this._sidebarWidget.showWidget();
             }
-            if (sideToHide) {
-                this._detaching = true;
-                sideToHide.detach();
-                delete this._detaching;
-            }
+            if (sideToHide)
+                sideToHide.hideWidget();
 
             this._resizerElement.classList.add("hidden");
             shadowToShow.classList.remove("hidden");
             shadowToShow.classList.add("maximized");
             shadowToHide.classList.add("hidden");
             shadowToHide.classList.remove("maximized");
             this._removeAllLayoutProperties();
             this.doResize();
         }
 
@@ skipping 34 matching lines @@
         if (this._showMode === WebInspector.SplitWidget.ShowMode.Both)
             animate = false;
 
         this._cancelAnimation();
         this._mainElement.classList.remove("maximized", "hidden");
         this._sidebarElement.classList.remove("maximized", "hidden");
         this._resizerElement.classList.remove("hidden");
         this.setResizable(true);
 
         // Make sure main is the first in the children list.
+        this.suspendInvalidations();
         if (this._sidebarWidget)
-            this._sidebarWidget.show(this.element);
+            this._sidebarWidget.showWidget();
         if (this._mainWidget)
-            this._mainWidget.show(this.element, this._sidebarWidget ? this._sidebarWidget.element : null);
+            this._mainWidget.showWidget();
+        this.resumeInvalidations();
         // Order widgets in DOM properly.
         this.setSecondIsSidebar(this._secondIsSidebar);
 
         this._sidebarSizeDIP = -1;
         this._updateShowMode(WebInspector.SplitWidget.ShowMode.Both);
         this._updateLayout(animate);
     },
 
     /**
      * @param {boolean} resizable
@@ skipping 517 matching lines @@
         this._showHideSidebarButton.classList.toggle("toggled-hide", !sidebarHidden);
         this._showHideSidebarButton.classList.toggle("top-sidebar-show-hide-button", !this.isVertical() && !this.isSidebarSecond());
         this._showHideSidebarButton.classList.toggle("right-sidebar-show-hide-button", this.isVertical() && this.isSidebarSecond());
         this._showHideSidebarButton.classList.toggle("bottom-sidebar-show-hide-button", !this.isVertical() && this.isSidebarSecond());
         this._showHideSidebarButton.classList.toggle("left-sidebar-show-hide-button", this.isVertical() && !this.isSidebarSecond());
         this._showHideSidebarButton.title = sidebarHidden ? WebInspector.UIString("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hide %s", this._showHideSidebarButtonTitle);
     },
 
     __proto__: WebInspector.Widget.prototype
 }