Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2157363006: DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 /** 242 /**
243 * @param {string} url 243 * @param {string} url
244 */ 244 */
245 setPage: function(url) 245 setPage: function(url)
246 { 246 {
247 if (this._objectPropertiesView) { 247 if (this._objectPropertiesView) {
248 this._objectPropertiesView.detach(); 248 this._objectPropertiesView.detach();
249 delete this._objectPropertiesView; 249 delete this._objectPropertiesView;
250 } 250 }
251 if (this._extensionView) 251 if (this._extensionView)
252 this._extensionView.detach(true); 252 this._extensionView.detach();
253 253
254 this._extensionView = new WebInspector.ExtensionView(this._server, this. _id, url, "extension fill"); 254 this._extensionView = new WebInspector.ExtensionView(this._server, this. _id, url, "extension fill");
255 this._extensionView.show(this.element); 255 this._extensionView.show(this.element);
256 256
257 if (!this.element.style.height) 257 if (!this.element.style.height)
258 this.setHeight("150px"); 258 this.setHeight("150px");
259 }, 259 },
260 260
261 /** 261 /**
262 * @param {string} height 262 * @param {string} height
(...skipping 16 matching lines...) Expand all
279 callback(error.toString()); 279 callback(error.toString());
280 else 280 else
281 this._setObject(/** @type {!WebInspector.RemoteObject} */ (result), title, callback); 281 this._setObject(/** @type {!WebInspector.RemoteObject} */ (result), title, callback);
282 }, 282 },
283 283
284 _createObjectPropertiesView: function() 284 _createObjectPropertiesView: function()
285 { 285 {
286 if (this._objectPropertiesView) 286 if (this._objectPropertiesView)
287 return; 287 return;
288 if (this._extensionView) { 288 if (this._extensionView) {
289 this._extensionView.detach(true); 289 this._extensionView.detach();
290 delete this._extensionView; 290 delete this._extensionView;
291 } 291 }
292 this._objectPropertiesView = new WebInspector.ExtensionNotifierView(this ._server, this._id); 292 this._objectPropertiesView = new WebInspector.ExtensionNotifierView(this ._server, this._id);
293 this._objectPropertiesView.show(this.element); 293 this._objectPropertiesView.show(this.element);
294 }, 294 },
295 295
296 /** 296 /**
297 * @param {!WebInspector.RemoteObject} object 297 * @param {!WebInspector.RemoteObject} object
298 * @param {string} title 298 * @param {string} title
299 * @param {function(?string=)} callback 299 * @param {function(?string=)} callback
(...skipping 10 matching lines...) Expand all
310 if (!title) 310 if (!title)
311 section.titleLessMode(); 311 section.titleLessMode();
312 section.expand(); 312 section.expand();
313 section.editable = false; 313 section.editable = false;
314 this._objectPropertiesView.element.appendChild(section.element); 314 this._objectPropertiesView.element.appendChild(section.element);
315 callback(); 315 callback();
316 }, 316 },
317 317
318 __proto__: WebInspector.View.prototype 318 __proto__: WebInspector.View.prototype
319 } 319 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698