Make PasswordManager::pending_login_managers_ a vector of unique_ptr

Make PasswordManager::pending_login_managers_ a vector of unique_ptr

...instead of a ScopedVector.

BUG=555132
Committed: https://crrev.com/ae4bd799ff094cd71401bf3672569356fb124f3c
Cr-Commit-Position: refs/heads/master@{#406259}

[vabr (Chromium), 2016-07-19 10:03:14]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 10:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 10:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 10:47:14]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-07-19 12:41:37]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:41:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-19 12:42:26]

vabr@chromium.org changed reviewers:
+ msramek@chromium.org

[vabr (Chromium), 2016-07-19 12:42:27]

Hi msramek@!

Could you please review this CL? The nature is not specific to passwords.

Cheers,
Vaclav

[msramek, 2016-07-19 13:00:04]

LGTM

FWIW, I'm not a great fan of "auto" outside complicated for loops, but I don't
feel strongly about it :)

[vabr (Chromium), 2016-07-19 13:04:43]

On 2016/07/19 13:00:04, msramek wrote:
> LGTM
> 
> FWIW, I'm not a great fan of "auto" outside complicated for loops, but I don't
> feel strongly about it :)

Thanks!

I know auto can be controversial. In this case my two rules for introducing auto
were:
(1) replacing iterator types: because the types are awkwardly long, and the
assignment is often something = begin(), end() or find*(), which makes it clear
it is an iterator
(2) replacing unique_ptr: because it is awkwardly long as well, and when using
WrapUnique on the right-hand side, the type is again clear

Cheers,
Vaclav

[vabr (Chromium), 2016-07-19 13:06:10]

https://codereview.chromium.org/2157333002/diff/60001/components/password_man...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/2157333002/diff/60001/components/password_man...
components/password_manager/core/browser/password_manager.cc:847:
PasswordFormManager* matched_manager = nullptr;
In particular here I actually replaced auto with the concrete type, because it
is (now) reasonably long, so I'm happy to make the code more penetrable for a
human reader.

[vabr (Chromium), 2016-07-19 13:06:16]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-07-19 13:06:20]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:06:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:15:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-19 13:15:40]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 13:16:50]

Description was changed from

==========
Make PasswordManager::pending_login_managers_ a vector of unique_ptr

...instead of a ScopedVector.

BUG=555132
==========

to

==========
Make PasswordManager::pending_login_managers_ a vector of unique_ptr

...instead of a ScopedVector.

BUG=555132

Committed: https://crrev.com/ae4bd799ff094cd71401bf3672569356fb124f3c
Cr-Commit-Position: refs/heads/master@{#406259}
==========

[commit-bot: I haz the power, 2016-07-19 13:16:51]

Patchset 4 (id:??) landed as
https://crrev.com/ae4bd799ff094cd71401bf3672569356fb124f3c
Cr-Commit-Position: refs/heads/master@{#406259}