Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 2157333002: Make PasswordManager::pending_login_managers_ a vector of unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@555132_no_old_login_managers
Patch Set: Undo unrelated change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index 1a2764271f58330eaff9298c335e7fd126316479..888d5c129b31a49d16c39d4de6529cfd116675ed 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
#include "base/stl_util.h"
#include "build/build_config.h"
@@ -236,7 +235,7 @@ class PasswordManager : public LoginModel {
// When a form is "seen" on a page, a PasswordFormManager is created
// and stored in this collection until user navigates away from page.
- ScopedVector<PasswordFormManager> pending_login_managers_;
+ std::vector<std::unique_ptr<PasswordFormManager>> pending_login_managers_;
// When the user submits a password/credential, this contains the
// PasswordFormManager for the form in question until we deem the login

Powered by Google App Engine
This is Rietveld 408576698