Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2157283003: [arm64] Avoid signed arithmetic in AddWithCarry. (Closed)

Created:
4 years, 5 months ago by jbramley
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Avoid signed arithmetic in AddWithCarry. This avoids implementation-defined signed overflow in the simulator's AddWithCarry implementation. The implementation of AddWithCarry now uses unsigned arithmetic exclusively. Testing coverage is also significantly improved. BUG= Committed: https://crrev.com/6ae7f2b5d8df71a97bdcec6294bce060a4a7fb99 Cr-Commit-Position: refs/heads/master@{#37895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -177 lines) Patch
M src/arm64/simulator-arm64.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 9 chunks +49 lines, -46 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 2 chunks +369 lines, -126 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 5 months ago (2016-07-19 13:03:20 UTC) #2
titzer
LGTM. Thanks!
4 years, 5 months ago (2016-07-19 13:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157283003/1
4 years, 5 months ago (2016-07-20 08:50:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 09:15:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:15:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ae7f2b5d8df71a97bdcec6294bce060a4a7fb99
Cr-Commit-Position: refs/heads/master@{#37895}

Powered by Google App Engine
This is Rietveld 408576698