Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: src/arm64/simulator-arm64.h

Issue 2157283003: [arm64] Avoid signed arithmetic in AddWithCarry. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/simulator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_SIMULATOR_ARM64_H_ 5 #ifndef V8_ARM64_SIMULATOR_ARM64_H_
6 #define V8_ARM64_SIMULATOR_ARM64_H_ 6 #define V8_ARM64_SIMULATOR_ARM64_H_
7 7
8 #include <stdarg.h> 8 #include <stdarg.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 634 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 return false; 645 return false;
646 } 646 }
647 } 647 }
648 648
649 bool ConditionFailed(Condition cond) { 649 bool ConditionFailed(Condition cond) {
650 return !ConditionPassed(cond); 650 return !ConditionPassed(cond);
651 } 651 }
652 652
653 template<typename T> 653 template<typename T>
654 void AddSubHelper(Instruction* instr, T op2); 654 void AddSubHelper(Instruction* instr, T op2);
655 template<typename T> 655 template <typename T>
656 T AddWithCarry(bool set_flags, 656 T AddWithCarry(bool set_flags, T left, T right, int carry_in = 0);
657 T src1,
658 T src2,
659 T carry_in = 0);
660 template<typename T> 657 template<typename T>
661 void AddSubWithCarry(Instruction* instr); 658 void AddSubWithCarry(Instruction* instr);
662 template<typename T> 659 template<typename T>
663 void LogicalHelper(Instruction* instr, T op2); 660 void LogicalHelper(Instruction* instr, T op2);
664 template<typename T> 661 template<typename T>
665 void ConditionalCompareHelper(Instruction* instr, T op2); 662 void ConditionalCompareHelper(Instruction* instr, T op2);
666 void LoadStoreHelper(Instruction* instr, 663 void LoadStoreHelper(Instruction* instr,
667 int64_t offset, 664 int64_t offset,
668 AddrMode addrmode); 665 AddrMode addrmode);
669 void LoadStorePairHelper(Instruction* instr, AddrMode addrmode); 666 void LoadStorePairHelper(Instruction* instr, AddrMode addrmode);
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
908 Simulator::current(isolate)->PopAddress(); 905 Simulator::current(isolate)->PopAddress();
909 } 906 }
910 }; 907 };
911 908
912 #endif // !defined(USE_SIMULATOR) 909 #endif // !defined(USE_SIMULATOR)
913 910
914 } // namespace internal 911 } // namespace internal
915 } // namespace v8 912 } // namespace v8
916 913
917 #endif // V8_ARM64_SIMULATOR_ARM64_H_ 914 #endif // V8_ARM64_SIMULATOR_ARM64_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm64/simulator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698