Add in row offset if self-composited.

Add in row offset if self-composited.

Table cells and rows are in the same coordinate space. So to go from table offset
to row, add in the table cell's location() and subtract out the row's.

BUG=616600
Committed: https://crrev.com/8c25207f8791f1c97440ffc7c4c13dfc34abead1
Cr-Commit-Position: refs/heads/master@{#406409}

[chrishtr, 2016-07-18 22:55:21]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
Account for table row offset when computing visual rects.

BUG=616600
==========

[chrishtr, 2016-07-18 23:00:57]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2016-07-18 23:00:58]

This was broken by https://codereview.chromium.org/2073563002. Turns out the row
and cell
are in the same transform & flipping coordinate space, but with different
offsets.

[wkorman, 2016-07-18 23:45:02]

lgtm

[chrishtr, 2016-07-19 16:09:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-19 16:09:22]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2157243002/#ps100001
(title: "none")

[commit-bot: I haz the power, 2016-07-19 16:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:44:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-07-19 21:34:37]

Description was changed from

==========
Account for table row offset when computing visual rects.

BUG=616600
==========

to

==========
Add in row offset if self-composited.

Table cells and rows are in the same coordinate space. So to go from table
offset
to row, add in the table cell's location() and subtract out the row's.

BUG=616600
==========

[chrishtr, 2016-07-19 21:36:19]

Updated. It turns out the rows and cells really are in the same coordinate
space. The bug
to be fixed was when the ancestor was the row. In that case, the way to go
between the 
coordinate spaces is to subtract off the topLeftLocation() of the cell and add
back on the topLeftLocation() of the row.

[wkorman, 2016-07-19 21:49:22]

lgtm

https://codereview.chromium.org/2157243002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-repaint-by-all-imagesource.html
(right):

https://codereview.chromium.org/2157243002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-repaint-by-all-imagesource.html:130:
function repaintTestAt(i, j) {
This looks like it is from a different change?

[chrishtr, 2016-07-19 21:55:06]

https://codereview.chromium.org/2157243002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-repaint-by-all-imagesource.html
(right):

https://codereview.chromium.org/2157243002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-repaint-by-all-imagesource.html:130:
function repaintTestAt(i, j) {
On 2016/07/19 at 21:49:21, wkorman wrote:
> This looks like it is from a different change?

Removed. Was for debugging.

[chrishtr, 2016-07-19 21:55:57]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-19 21:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2157243002/#ps160001
(title: "none")

[commit-bot: I haz the power, 2016-07-19 21:56:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 23:16:17]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-19 23:16:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 23:18:36]

Description was changed from

==========
Add in row offset if self-composited.

Table cells and rows are in the same coordinate space. So to go from table
offset
to row, add in the table cell's location() and subtract out the row's.

BUG=616600
==========

to

==========
Add in row offset if self-composited.

Table cells and rows are in the same coordinate space. So to go from table
offset
to row, add in the table cell's location() and subtract out the row's.

BUG=616600

Committed: https://crrev.com/8c25207f8791f1c97440ffc7c4c13dfc34abead1
Cr-Commit-Position: refs/heads/master@{#406409}
==========

[commit-bot: I haz the power, 2016-07-19 23:18:37]

Patchset 9 (id:??) landed as
https://crrev.com/8c25207f8791f1c97440ffc7c4c13dfc34abead1
Cr-Commit-Position: refs/heads/master@{#406409}