Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2157243002: Add in row offset if self-composited. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/invalidate-cell-in-row-with-offset-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 7fc355d09d9cc91257408c2eebb52256dbaf869e..c092ef78d30120412d10d5cd9a36fc153bb66af6 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2043,10 +2043,15 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
bool ancestorSkipped;
bool filterOrReflectionSkipped;
LayoutObject* container = this->container(ancestor, &ancestorSkipped, &filterOrReflectionSkipped);
- // Skip table row because cells and rows are in the same coordinate space, except when we're already at the ancestor.
- if (container->isTableRow() && container != ancestor) {
- DCHECK(isTableCell());
- container = container->parent();
+ LayoutBox* tableRowContainer = nullptr;
+ // Skip table row because cells and rows are in the same coordinate space
+ // (see below, however for more comments about when |ancestor| is the table row).
+ if (container->isTableRow()) {
+ DCHECK(isTableCell() && parentBox() == container);
+ if (container != ancestor)
+ container = container->parent();
+ else
+ tableRowContainer = toLayoutBox(container);
}
if (!container)
return true;
@@ -2063,12 +2068,15 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
rect = LayoutRect(layer()->transform()->mapRect(enclosingIntRect(rect)));
}
LayoutPoint topLeft = rect.location();
- // TODO(wkorman): Look into and document why this conditional is needed.
- // Currently present following logic in PaintLayer::updateLayerPosition.
- if (container->isBox())
+ if (container->isBox()) {
topLeft.moveBy(topLeftLocation(toLayoutBox(container)));
- else
- topLeft.move(locationOffset());
+ // If the row is the ancestor, however, add its offset back in. In effect, this passes from the joint <td> / <tr>
+ // coordinate space to the parent space, then back to <tr> / <td>.
+ if (tableRowContainer)
+ topLeft.moveBy(-tableRowContainer->topLeftLocation(toLayoutBox(container)));
+ } else {
+ topLeft.moveBy(location());
+ }
const ComputedStyle& styleToUse = styleRef();
EPosition position = styleToUse.position();
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/invalidate-cell-in-row-with-offset-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698