Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: Source/core/dom/Element.cpp

Issue 215723002: Enable style sharing for <option> and <optgroup> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 6603f42fd0700ea5c6fe48be28e9464b15a89ea1..716a46dbc3e2f848f772e50fc5d837fa3fdbb55b 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -3360,11 +3360,6 @@ bool Element::supportsStyleSharing() const
|| isHTMLAppletElement(*this)
|| isHTMLCanvasElement(*this))
return false;
- // FIXME: We should share style for option and optgroup whenever possible.
- // Before doing so, we need to resolve issues in HTMLSelectElement::recalcListItems
- // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cgi?id=88405
- if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this))
- return false;
if (FullscreenElementStack::isActiveFullScreenElement(this))
return false;
return true;
« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698