Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 215723002: Enable style sharing for <option> and <optgroup> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3342 matching lines...) Expand 10 before | Expand all | Expand 10 after
3353 return false; 3353 return false;
3354 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system. 3354 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system.
3355 // See comments in RenderObject::setStyle(). 3355 // See comments in RenderObject::setStyle().
3356 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing? 3356 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing?
3357 if (isHTMLFrameElementBase(*this) 3357 if (isHTMLFrameElementBase(*this)
3358 || isHTMLEmbedElement(*this) 3358 || isHTMLEmbedElement(*this)
3359 || isHTMLObjectElement(*this) 3359 || isHTMLObjectElement(*this)
3360 || isHTMLAppletElement(*this) 3360 || isHTMLAppletElement(*this)
3361 || isHTMLCanvasElement(*this)) 3361 || isHTMLCanvasElement(*this))
3362 return false; 3362 return false;
3363 // FIXME: We should share style for option and optgroup whenever possible.
3364 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3365 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3366 if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this))
3367 return false;
3368 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3363 if (FullscreenElementStack::isActiveFullScreenElement(this))
3369 return false; 3364 return false;
3370 return true; 3365 return true;
3371 } 3366 }
3372 3367
3373 } // namespace WebCore 3368 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698