Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 215723002: Enable style sharing for <option> and <optgroup> (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Visibility:
Public.

Description

Enable style sharing for <option> and <optgroup> This was attempted long ago but then reverted because it broke some tests related to text transforms and disabled states [1]. Those tests don't seem to fail anymore though and I can't think of any reason why sharing style should change the rendering of RenderMenuList. Enabling this makes http://jsfiddle.net/p4saV/1/ 56% faster where you have 5000 <option>'s and all of bootstrap's CSS. [1] https://bugs.webkit.org/show_bug.cgi?id=88405 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M Source/core/css/resolver/SharedStyleFinder.cpp View 3 chunks +9 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
esprehn
6 years, 9 months ago (2014-03-27 22:42:15 UTC) #1
eseidel
lgtm I'm confused why we still have all these manual exclusions. I'm surprised that these ...
6 years, 9 months ago (2014-03-27 23:07:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/215723002/1
6 years, 9 months ago (2014-03-27 23:07:55 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:11:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 23:11:33 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 23:19:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/215723002/1
6 years, 9 months ago (2014-03-27 23:19:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:45:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-27 23:45:02 UTC) #9
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-28 01:21:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/215723002/1
6 years, 9 months ago (2014-03-28 01:21:31 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 02:30:21 UTC) #12
Message was sent while issue was closed.
Change committed as 170249

Powered by Google App Engine
This is Rietveld 408576698