Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2157213002: Cherry-pick Skia infra fixes to m53 (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@m53
Target Ref:
refs/heads/chrome/m53
Project:
skia
Visibility:
Public.

Description

Cherry-pick Skia infra fixes to m53 so that Windows and Android bots can run tests. BUG=chromium:629281 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157213002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Author: borenet <borenet@chromium.org>; Date: Thu Jun 30 05:20:03 2016 -0700 Add Android SDK asset This will allow us to use CIPD to install the Android SDK on bots. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002 Review-Url: https://codereview.chromium.org/2086003002 Author: skia.buildbots <skia.buildbots@gmail.com>; Date: Fri Jul 1 17:29:18 2016 -0700 Update Win toolchain BUG=chromium:629281 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116173002 NOTREECHECKS=true NOTRY=true TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2116173002

Patch Set 1 #

Patch Set 2 : Add Android SDK asset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -137 lines) Patch
D infra/bots/android_sdk.isolate View 1 1 chunk +0 lines, -7 lines 0 comments Download
D infra/bots/android_sdk_hash View 1 1 chunk +0 lines, -1 line 0 comments Download
A infra/bots/assets/android_sdk/VERSION View 1 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/common.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/android_sdk/create.py View 1 1 chunk +39 lines, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/create_and_upload.py View 1 2 chunks +6 lines, -1 line 0 comments Download
A + infra/bots/assets/android_sdk/download.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/android_sdk/upload.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D infra/bots/isolate_android_sdk.py View 1 1 chunk +0 lines, -129 lines 0 comments Download
M infra/bots/win_toolchain_hash.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dogben
4 years, 5 months ago (2016-07-18 22:06:45 UTC) #3
borenet
You're missing the win toolchain change: https://skia.googlesource.com/skia/+/f1120ea72cd04c686a11d557d3cc3d4ac47fd350
4 years, 5 months ago (2016-07-19 11:06:49 UTC) #5
dogben
4 years, 5 months ago (2016-07-19 13:02:30 UTC) #6
On 2016/07/19 at 11:06:49, borenet wrote:
> You're missing the win toolchain change:
https://skia.googlesource.com/skia/+/f1120ea72cd04c686a11d557d3cc3d4ac47fd350

Starting over.

Powered by Google App Engine
This is Rietveld 408576698