Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 21572002: Add UMA entry for intranet SSL warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed spaces introduced by rebasing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verify_proc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index 21f79d608eaaacf99ac731e7512b7c756d87fe04..a53d10a0845c710cbedc87c898f0a884729dd862 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -1356,72 +1356,4 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
CertVerifyProcWeakDigestTest,
testing::ValuesIn(kVerifyMixedTestData));
-struct NonUniqueNameTestData {
- bool is_unique;
- const char* hostname;
-};
-
-// Google Test pretty-printer.
-void PrintTo(const NonUniqueNameTestData& data, std::ostream* os) {
- ASSERT_TRUE(data.hostname);
- *os << " hostname: " << testing::PrintToString(data.hostname)
- << "; is_unique: " << testing::PrintToString(data.is_unique);
-}
-
-const NonUniqueNameTestData kNonUniqueNameTestData[] = {
- // Domains under ICANN-assigned domains.
- { true, "google.com" },
- { true, "google.co.uk" },
- // Domains under private registries.
- { true, "appspot.com" },
- { true, "test.appspot.com" },
- // IPv4 addresses (in various forms).
- { true, "8.8.8.8" },
- { true, "1.2.3" },
- { true, "14.15" },
- { true, "676768" },
- // IPv6 addresses.
- { true, "FEDC:ba98:7654:3210:FEDC:BA98:7654:3210" },
- { true, "::192.9.5.5" },
- { true, "FEED::BEEF" },
- // 'internal'/non-IANA assigned domains.
- { false, "intranet" },
- { false, "intranet." },
- { false, "intranet.example" },
- { false, "host.intranet.example" },
- // gTLDs under discussion, but not yet assigned.
- { false, "intranet.corp" },
- { false, "example.tech" },
- { false, "intranet.internal" },
- // Invalid host names are treated as unique - but expected to be
- // filtered out before then.
- { true, "junk)(£)$*!@~#" },
- { true, "w$w.example.com" },
- { true, "nocolonsallowed:example" },
- { true, "[::4.5.6.9]" },
-};
-
-class CertVerifyProcNonUniqueNameTest
- : public testing::TestWithParam<NonUniqueNameTestData> {
- public:
- virtual ~CertVerifyProcNonUniqueNameTest() {}
-
- protected:
- bool IsUnique(const std::string& hostname) {
- return !CertVerifyProc::IsHostnameNonUnique(hostname);
- }
-};
-
-// Test that internal/non-unique names are properly identified as such, but
-// that IP addresses and hosts beneath registry-controlled domains are flagged
-// as unique names.
-TEST_P(CertVerifyProcNonUniqueNameTest, IsHostnameNonUnique) {
- const NonUniqueNameTestData& test_data = GetParam();
-
- EXPECT_EQ(test_data.is_unique, IsUnique(test_data.hostname));
-}
-
-INSTANTIATE_TEST_CASE_P(, CertVerifyProcNonUniqueNameTest,
- testing::ValuesIn(kNonUniqueNameTestData));
-
} // namespace net
« no previous file with comments | « net/cert/cert_verify_proc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698