Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2157043002: [Merge M53] Embed address normalization rewriting rules. (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M53] Embed address normalization rewriting rules. This CL adds a table of string rewrite rules, keyed by country code, to aid in address normalization when comparing autofill profiles. The rules for each country code are stored as static constant string tables and compiled to regular expression replacement params on first use, and subsequently cached. The address rewriting rules are applied when comparing and merging the state, city, and street address of a profile to correct for synonyms, abbreviations, and some common mispellings. R=mathp@chromium.org, sebsg@chromium.org BUG=618095 Review-Url: https://codereview.chromium.org/2137533002 Cr-Commit-Position: refs/heads/master@{#404431} (cherry picked from commit 26ac4e202f50ab9dd60117c529479a14cd3640e8) Committed: https://chromium.googlesource.com/chromium/src/+/6852939d9b7f156119f01c5b95542d939665c37a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4031 lines, -46 lines) Patch
M components/autofill.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter.h View 1 chunk +64 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter_rules.cc View 1 chunk +3500 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter_unittest.cc View 1 chunk +284 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.cc View 10 chunks +27 lines, -40 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years, 5 months ago (2016-07-18 18:31:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6852939d9b7f156119f01c5b95542d939665c37a.

Powered by Google App Engine
This is Rietveld 408576698