Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2137533002: Embed address normalization rewriting rules. (Closed)

Created:
4 years, 5 months ago by Roger McFarlane (Chromium)
Modified:
4 years, 5 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Embed address normalization rewriting rules. This CL adds a table of string rewrite rules, keyed by country code, to aid in address normalization when comparing autofill profiles. The rules for each country code are stored as static constant string tables and compiled to regular expression replacement params on first use, and subsequently cached. The address rewriting rules are applied when comparing and merging the state, city, and street address of a profile to correct for synonyms, abbreviations, and some common mispellings. R=mathp@chromium.org, sebsg@chromium.org BUG=618095 Committed: https://crrev.com/26ac4e202f50ab9dd60117c529479a14cd3640e8 Cr-Commit-Position: refs/heads/master@{#404431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4031 lines, -46 lines) Patch
M components/autofill.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter.h View 1 chunk +64 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter_rules.cc View 1 chunk +3500 lines, -0 lines 0 comments Download
A components/autofill/core/browser/address_rewriter_unittest.cc View 1 chunk +284 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.cc View 10 chunks +27 lines, -40 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Roger McFarlane (Chromium)
This is a merge of https://codereview.chromium.org/2121253002/ [reverted] https://codereview.chromium.org/2130873002/ Which embed the address normalization rules and ...
4 years, 5 months ago (2016-07-08 14:42:34 UTC) #1
Mathieu
lgtm, thanks
4 years, 5 months ago (2016-07-08 15:00:25 UTC) #2
sebsg
LGTM!
4 years, 5 months ago (2016-07-08 15:25:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137533002/1
4 years, 5 months ago (2016-07-08 15:34:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 17:45:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 17:47:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26ac4e202f50ab9dd60117c529479a14cd3640e8
Cr-Commit-Position: refs/heads/master@{#404431}

Powered by Google App Engine
This is Rietveld 408576698