Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2156933003: cc: Add SwapAck watchdog. (Closed)

Created:
4 years, 5 months ago by brianderson
Modified:
4 years, 4 months ago
Reviewers:
sunnyps, sdoyon, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org, aelias_OOO_until_Jul13, klobag.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add SwapAck watchdog. This CHECKs if we haven't received a swap ack for more than 8 seconds. This is enabled behind a feature flag which will allow us to control platforms, versions, and percent of of devices the watchdog is enabled on. BUG=602486, 637102

Patch Set 1 #

Patch Set 2 : Use feature flag #

Patch Set 3 : whitespace #

Patch Set 4 : Change to 8 seconds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M cc/proto/layer_tree_settings.proto View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/compositor_timing_history.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M cc/scheduler/compositor_timing_history.cc View 1 2 3 6 chunks +29 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (13 generated)
brianderson
ptal. +sunnyps for cc/ +piman for content/ +sdoyon as the Finch ambassador
4 years, 4 months ago (2016-08-11 22:22:29 UTC) #12
piman
4 years, 4 months ago (2016-08-11 22:30:17 UTC) #13
I commented on the design doc, I don't think we should CHECK.

Powered by Google App Engine
This is Rietveld 408576698