Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 215693002: [Android] Allow non-editable partner bookmarks. (Closed)

Created:
6 years, 9 months ago by aruslan
Modified:
6 years, 9 months ago
Reviewers:
Ted C, aruslan1
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Allow non-editable partner bookmarks. BUG=352263 TESTS=PartnerBookmarksShimTest NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260233

Patch Set 1 #

Patch Set 2 : Forgot to revert sanity-check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -10 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 1 5 chunks +36 lines, -9 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aruslan1
PTAL, thanks!
6 years, 9 months ago (2014-03-27 23:07:03 UTC) #1
Ted C
lgtm
6 years, 9 months ago (2014-03-27 23:18:11 UTC) #2
aruslan1
The CQ bit was checked by aruslan@google.com
6 years, 9 months ago (2014-03-28 18:47:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/215693002/20001
6 years, 9 months ago (2014-03-28 18:49:53 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 19:20:18 UTC) #5
Message was sent while issue was closed.
Change committed as 260233

Powered by Google App Engine
This is Rietveld 408576698