Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc

Issue 215693002: [Android] Allow non-editable partner bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to revert sanity-check. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/android/bookmarks/partner_bookmarks_shim.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 profile_.reset(new TestingProfile()); 63 profile_.reset(new TestingProfile());
64 profile_->CreateBookmarkModel(true); 64 profile_->CreateBookmarkModel(true);
65 65
66 model_ = BookmarkModelFactory::GetForProfile(profile_.get()); 66 model_ = BookmarkModelFactory::GetForProfile(profile_.get());
67 test::WaitForBookmarkModelToLoad(model_); 67 test::WaitForBookmarkModelToLoad(model_);
68 } 68 }
69 69
70 virtual void TearDown() OVERRIDE { 70 virtual void TearDown() OVERRIDE {
71 PartnerBookmarksShim::ClearInBrowserContextForTesting(profile_.get()); 71 PartnerBookmarksShim::ClearInBrowserContextForTesting(profile_.get());
72 PartnerBookmarksShim::ClearPartnerModelForTesting(); 72 PartnerBookmarksShim::ClearPartnerModelForTesting();
73 PartnerBookmarksShim::EnablePartnerBookmarksEditing();
73 profile_.reset(NULL); 74 profile_.reset(NULL);
74 } 75 }
75 76
76 scoped_ptr<TestingProfile> profile_; 77 scoped_ptr<TestingProfile> profile_;
77 78
78 base::MessageLoopForUI message_loop_; 79 base::MessageLoopForUI message_loop_;
79 content::TestBrowserThread ui_thread_; 80 content::TestBrowserThread ui_thread_;
80 content::TestBrowserThread file_thread_; 81 content::TestBrowserThread file_thread_;
81 82
82 BookmarkModel* model_; 83 BookmarkModel* model_;
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0); 365 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
365 ASSERT_TRUE(shim->IsLoaded()); 366 ASSERT_TRUE(shim->IsLoaded());
366 367
367 const BookmarkNode* partner_bookmark1 = shim->GetNodeByID(3); 368 const BookmarkNode* partner_bookmark1 = shim->GetNodeByID(3);
368 const BookmarkNode* partner_bookmark2 = shim->GetNodeByID(5); 369 const BookmarkNode* partner_bookmark2 = shim->GetNodeByID(5);
369 370
370 EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1)); 371 EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
371 EXPECT_FALSE(shim->IsReachable(partner_bookmark2)); 372 EXPECT_FALSE(shim->IsReachable(partner_bookmark2));
372 } 373 }
373 } 374 }
375
376 TEST_F(PartnerBookmarksShimTest, DisableEditing) {
377 PartnerBookmarksShim* shim = partner_bookmarks_shim();
378 shim->AddObserver(&observer_);
379
380 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
381 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
382
383 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
384 root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
385
386 BookmarkNode* partner_bookmark1 = new BookmarkNode(3, GURL("http://a"));
387 partner_bookmark1->set_type(BookmarkNode::URL);
388 partner_bookmark1->SetTitle(base::ASCIIToUTF16("a"));
389 root_partner_node->Add(partner_bookmark1, root_partner_node->child_count());
390
391 BookmarkNode* partner_bookmark2 = new BookmarkNode(3, GURL("http://b"));
392 partner_bookmark2->set_type(BookmarkNode::URL);
393 partner_bookmark2->SetTitle(base::ASCIIToUTF16("b"));
394 root_partner_node->Add(partner_bookmark2, root_partner_node->child_count());
395
396 ASSERT_FALSE(shim->IsLoaded());
397 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
398 shim->SetPartnerBookmarksRoot(root_partner_node);
399 ASSERT_TRUE(shim->IsLoaded());
400
401 // Check that edits work by default.
402 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(2);
403 shim->RenameBookmark(partner_bookmark1, base::ASCIIToUTF16("a2.com"));
404 shim->RemoveBookmark(partner_bookmark2);
405 EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
406 EXPECT_FALSE(shim->IsReachable(partner_bookmark2));
407
408 // Disable edits and check that edits are not applied anymore.
409 PartnerBookmarksShim::DisablePartnerBookmarksEditing();
410 EXPECT_EQ(base::ASCIIToUTF16("a"), shim->GetTitle(partner_bookmark1));
411 EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
412 }
OLDNEW
« no previous file with comments | « chrome/browser/android/bookmarks/partner_bookmarks_shim.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698