[HBD] Remove PluginCache and reload plugin list when origin changes

third_party/WebKit/Source/core/page/Page.h

Index: third_party/WebKit/Source/core/page/Page.h
diff --git a/third_party/WebKit/Source/core/page/Page.h b/third_party/WebKit/Source/core/page/Page.h
index 6f75adeca66167b95faa128a92e802f37340a819..cde8291adb3d72381b241d287338abb79737f33b 100644
--- a/third_party/WebKit/Source/core/page/Page.h
+++ b/third_party/WebKit/Source/core/page/Page.h
@@ -119,7 +119,7 @@ public:
     ViewportDescription viewportDescription() const;
 
     static void refreshPlugins();
-    PluginData* pluginData() const;
+    PluginData* pluginData();
 
     EditorClient& editorClient() const { return *m_editorClient; }
     SpellCheckerClient& spellCheckerClient() const { return *m_spellCheckerClient; }
@@ -260,6 +260,8 @@ private:
 
     bool m_isCursorVisible;
 
+    RefPtr<SecurityOrigin> m_origin;

[alexmos, 2016/08/02 22:06:28]

I'll leave this to Blink reviewers, but storing m_origin on Page seems a little
strange to me, as Page contains multiple Frames, each with its own origin, so to
someone looking at Page.h it's unclear which origin this refers to, which might
lead to misusing this later.  IIUC, this is also not the same as main frame
origin, but rather what the main frame origin was the last time you queried
navigator.plugins. tommycli: I noticed you suggested moving the m_origin here
from PluginData - any reasons for that, as to me it actually makes a little more
sense to keep it localized inside PluginData?

[tommycli, 2016/08/02 23:03:16]

Thinking it over again, I think I was wrong. Maybe this should belong in
PluginData.

My latest thinking is a usage pattern such as:

if (!m_pluginData || !currentOrigin.isEqual(m_pluginData->origin()))
  m_pluginData = new PluginData(currentOrigin)

[alexmos, 2016/08/04 05:32:02]

Yes, I think something like that makes more sense; let's try it.

[trizzofo, 2016/08/06 01:30:46]

Done.

+
 #if ENABLE(ASSERT)
     bool m_isPainting;
 #endif