[HBD] Remove PluginCache and reload plugin list when origin changes

third_party/WebKit/Source/core/page/Page.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 101 matching lines @@
     static void platformColorsChanged();
 
     FrameHost& frameHost() const { return *m_frameHost; }
 
     void setNeedsRecalcStyleInAllFrames();
     void updateAcceleratedCompositingSettings();
 
     ViewportDescription viewportDescription() const;
 
     static void refreshPlugins();
-    PluginData* pluginData() const;
+    PluginData* pluginData();
 
     EditorClient& editorClient() const { return *m_editorClient; }
     SpellCheckerClient& spellCheckerClient() const { return *m_spellCheckerClient; }
 
     void setMainFrame(Frame*);
     Frame* mainFrame() const { return m_mainFrame; }
     // Escape hatch for existing code that assumes that the root frame is
     // always a LocalFrame. With OOPI, this is not always the case. Code that
     // depends on this will generally have to be rewritten to propagate any
     // necessary state through all renderer processes for that page and/or
@@ skipping 120 matching lines @@
 
     bool m_tabKeyCyclesThroughElements;
     bool m_defersLoading;
 
     float m_deviceScaleFactor;
 
     PageVisibilityState m_visibilityState;
 
     bool m_isCursorVisible;
 
+    RefPtr<SecurityOrigin> m_origin;

[alexmos, 2016/08/02 22:06:28]

I'll leave this to Blink reviewers, but storing m_origin on Page seems a little
strange to me, as Page contains multiple Frames, each with its own origin, so to
someone looking at Page.h it's unclear which origin this refers to, which might
lead to misusing this later.  IIUC, this is also not the same as main frame
origin, but rather what the main frame origin was the last time you queried
navigator.plugins. tommycli: I noticed you suggested moving the m_origin here
from PluginData - any reasons for that, as to me it actually makes a little more
sense to keep it localized inside PluginData?

[tommycli, 2016/08/02 23:03:16]

Thinking it over again, I think I was wrong. Maybe this should belong in
PluginData.

My latest thinking is a usage pattern such as:

if (!m_pluginData || !currentOrigin.isEqual(m_pluginData->origin()))
  m_pluginData = new PluginData(currentOrigin)

[alexmos, 2016/08/04 05:32:02]

Yes, I think something like that makes more sense; let's try it.

[trizzofo, 2016/08/06 01:30:46]

Done.

+
 #if ENABLE(ASSERT)
     bool m_isPainting;
 #endif
 
     // A pointer to all the interfaces provided to in-process Frames for this Page.
     // FIXME: Most of the members of Page should move onto FrameHost.
     Member<FrameHost> m_frameHost;
 
     Timer<Page> m_timerForCompressStrings;
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
 
 } // namespace blink
 
 #endif // Page_h