Issue 2156673002: Disallow theme colors with luminance > 0.94

Issue 2156673002: Disallow theme colors with luminance > 0.94 (Closed)

Created:
4 years, 5 months ago by mdjones

Modified:
4 years, 5 months ago

Reviewers:
gone

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Disallow theme colors with luminance > 0.94 BUG=606596, 621847 Committed: https://crrev.com/3a0b5749c0760340e61043000af4d09cad77f90e Cr-Commit-Position: refs/heads/master@{#405878}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 10 (4 generated)

mdjones

Turns out the patch to fix theme colors correctly is small. ptal

4 years, 5 months ago (2016-07-15 19:08:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156673002/1

4 years, 5 months ago (2016-07-15 21:00:04 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-07-15 22:25:46 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3a0b5749c0760340e61043000af4d09cad77f90e
Cr-Commit-Position: refs/heads/master@{#405878}