chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java - Issue 2156673002: Disallow theme colors with luminance > 0.94

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Issue 2156673002: Disallow theme colors with luminance > 0.94 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

index 026484db9880aacf161183b0740aabfd34546179..6d2cfb09fe2a22f7fcbb2ade28273fbc5ca8f74d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

@@ -391,7 +391,8 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {

mThemeColor = color;

// The default toolbar has specific colors to use.

- if (ColorUtils.isUsingDefaultToolbarColor(getResources(), color) && !isIncognito) {

+ if ((ColorUtils.isUsingDefaultToolbarColor(getResources(), color)

+ || !ColorUtils.isValidThemeColor(color)) && !isIncognito) {

setForegroundColor(ApiCompatibilityUtils.getColor(getResources(),

R.color.progress_bar_foreground));

setBackgroundColor(ApiCompatibilityUtils.getColor(getResources(),

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java ('k') | no next file » | no next file with comments »