Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/password_entry_editor_1.xml

Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add accessibility labels Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/password_entry_editor_1.xml
diff --git a/chrome/android/java/res/layout/password_entry_editor_1.xml b/chrome/android/java/res/layout/password_entry_editor_1.xml
new file mode 100644
index 0000000000000000000000000000000000000000..61b2298d78a9d9ede007cd6a57e4c2aa9e759603
--- /dev/null
+++ b/chrome/android/java/res/layout/password_entry_editor_1.xml
@@ -0,0 +1,157 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:fillViewport="true" >
+
+ <LinearLayout
+ android:id="@+id/password_entry_editor_1"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:orientation="vertical"
+ android:title="@string/password_entry_editor_title"
+ android:visibility="gone">
+
+ <TextView
+ android:text="@string/password_entry_editor_site_title"
+ android:textColor="@color/google_blue_700"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="10dp"
+ android:layout_marginStart="15dp"
+ android:gravity="center_vertical"
+ android:textAppearance="?android:attr/textAppearanceMedium" />
+
+ <LinearLayout
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:orientation="horizontal"
+ android:weightSum="1" >
Bernhard Bauer 2016/07/19 11:46:50 This is unnecessary -- the default is going to be
dozsa 2016/07/20 12:07:08 Done.
Bernhard Bauer 2016/07/20 14:25:56 Not really? I still see this.
dozsa 2016/07/20 15:32:59 Oops. Done now.
+
+ <TextView
+ android:id="@+id/password_entry_editor_url"
+ android:textColor="@color/default_text_color"
+ android:layout_width="fill_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="10dp"
+ android:layout_marginStart="15dp"
+ android:textAppearance="?android:attr/textAppearanceMedium" />
+
+ <View
+ android:layout_width="0dp"
+ android:layout_height="0dp"
+ android:layout_weight="1" />
+
+ <ImageButton
+ style="?android:attr/buttonStyleSmall"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_gravity="end"
+ android:layout_marginTop="10dp"
+ android:layout_marginEnd="15dp"
+ android:src="@drawable/clipboard_black"
+ android:contentDescription="@string/password_entry_editor_copy_stored_site" />
+
+ </LinearLayout>
+
+ <TextView
+ android:text="@string/password_entry_editor_username_title"
+ android:textColor="@color/google_blue_700"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="5dp"
+ android:layout_marginStart="15dp"
+ android:gravity="center_vertical"
+ android:textAppearance="?android:attr/textAppearanceMedium" />
+
+ <LinearLayout
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:orientation="horizontal"
+ android:weightSum="1" >
+
+ <TextView
+ android:id="@+id/password_entry_editor_name"
+ android:textColor="@color/default_text_color"
+ android:layout_width="fill_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="10dp"
+ android:layout_marginStart="15dp"
+ android:textAppearance="?android:attr/textAppearanceMedium"
+ android:contentDescription="@string/password_entry_editor_copy_stored_username" />
+
+ <View
+ android:layout_width="0dp"
+ android:layout_height="0dp"
+ android:layout_weight="1" />
+
+ <ImageButton
+ style="?android:attr/buttonStyleSmall"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_gravity="end"
+ android:layout_marginTop="10dp"
+ android:layout_marginEnd="15dp"
+ android:src="@drawable/clipboard_black" />
+
+ </LinearLayout>
+
+ <TextView
+ android:text="@string/password_entry_editor_password"
+ android:textColor="@color/google_blue_700"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="5dp"
+ android:layout_marginStart="15dp"
+ android:gravity="center_vertical"
+ android:textAppearance="?android:attr/textAppearanceMedium" />
+
+ <LinearLayout
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:orientation="horizontal"
+ android:weightSum="1" >
+
+ <TextView
+ android:id="@+id/password_entry_editor_password"
+ android:textColor="@color/default_text_color"
+ android:layout_width="fill_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="10dp"
+ android:layout_marginStart="15dp"
+ android:textAppearance="?android:attr/textAppearanceMedium" />
+
+ <View
+ android:layout_width="0dp"
+ android:layout_height="0dp"
+ android:layout_weight="1" />
+
+ <ImageButton
+ style="?android:attr/buttonStyleSmall"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_gravity="end"
+ android:layout_marginTop="10dp"
+ android:layout_marginEnd="15dp"
+ android:src="@drawable/eye_black"
+ android:contentDescription="@string/password_entry_editor_view_stored_password" />
+
+ <ImageButton
+ style="?android:attr/buttonStyleSmall"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_gravity="end"
+ android:layout_marginTop="10dp"
+ android:layout_marginEnd="15dp"
+ android:src="@drawable/clipboard_black"
+ android:contentDescription="@string/password_entry_editor_copy_stored_password" />
+
+ </LinearLayout>
+
+ </LinearLayout>
+
+</ScrollView>
« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698