chrome/android/java/res/layout/password_entry_editor_1.xml - Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner

Side by Side Diff: chrome/android/java/res/layout/password_entry_editor_1.xml

Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add accessibility labels Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="match_parent"

	8 android:layout_height="match_parent"

	9 android:fillViewport="true" >

	10

	11 <LinearLayout

	12 android:id="@+id/password_entry_editor_1"

	13 android:layout_width="match_parent"

	14 android:layout_height="wrap_content"

	15 android:orientation="vertical"

	16 android:title="@string/password_entry_editor_title"

	17 android:visibility="gone">

	18

	19 <TextView

	20 android:text="@string/password_entry_editor_site_title"

	21 android:textColor="@color/google_blue_700"

	22 android:layout_width="wrap_content"

	23 android:layout_height="wrap_content"

	24 android:layout_marginTop="10dp"

	25 android:layout_marginStart="15dp"

	26 android:gravity="center_vertical"

	27 android:textAppearance="?android:attr/textAppearanceMedium" />

	28

	29 <LinearLayout

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:orientation="horizontal"

	33 android:weightSum="1" >
	Bernhard Bauer 2016/07/19 11:46:50 This is unnecessary -- the default is going to be This is unnecessary -- the default is going to be the sum of the child weights. (Also, no space before the closing angle bracket). dozsa 2016/07/20 12:07:08 Done. Show quoted text On 2016/07/19 11:46:50, Bernhard Bauer wrote: > This is unnecessary -- the default is going to be the sum of the child weights. > > (Also, no space before the closing angle bracket). Done. Bernhard Bauer 2016/07/20 14:25:56 Not really? I still see this. Show quoted text On 2016/07/20 12:07:08, dozsa wrote: > On 2016/07/19 11:46:50, Bernhard Bauer wrote: > > This is unnecessary -- the default is going to be the sum of the child > weights. > > > > (Also, no space before the closing angle bracket). > > Done. Not really? I still see this. dozsa 2016/07/20 15:32:59 Oops. Done now. Show quoted text On 2016/07/20 14:25:56, Bernhard Bauer wrote: > On 2016/07/20 12:07:08, dozsa wrote: > > On 2016/07/19 11:46:50, Bernhard Bauer wrote: > > > This is unnecessary -- the default is going to be the sum of the child > > weights. > > > > > > (Also, no space before the closing angle bracket). > > > > Done. > > Not really? I still see this. Oops. Done now.
	34

	35 <TextView

	36 android:id="@+id/password_entry_editor_url"

	37 android:textColor="@color/default_text_color"

	38 android:layout_width="fill_parent"

	39 android:layout_height="wrap_content"

	40 android:layout_marginTop="10dp"

	41 android:layout_marginStart="15dp"

	42 android:textAppearance="?android:attr/textAppearanceMedium" />

	43

	44 <View

	45 android:layout_width="0dp"

	46 android:layout_height="0dp"

	47 android:layout_weight="1" />

	48

	49 <ImageButton

	50 style="?android:attr/buttonStyleSmall"

	51 android:layout_width="match_parent"

	52 android:layout_height="wrap_content"

	53 android:layout_gravity="end"

	54 android:layout_marginTop="10dp"

	55 android:layout_marginEnd="15dp"

	56 android:src="@drawable/clipboard_black"

	57 android:contentDescription="@string/password_entry_editor_copy_s tored_site" />

	58

	59 </LinearLayout>

	60

	61 <TextView

	62 android:text="@string/password_entry_editor_username_title"

	63 android:textColor="@color/google_blue_700"

	64 android:layout_width="wrap_content"

	65 android:layout_height="wrap_content"

	66 android:layout_marginTop="5dp"

	67 android:layout_marginStart="15dp"

	68 android:gravity="center_vertical"

	69 android:textAppearance="?android:attr/textAppearanceMedium" />

	70

	71 <LinearLayout

	72 android:layout_width="wrap_content"

	73 android:layout_height="wrap_content"

	74 android:orientation="horizontal"

	75 android:weightSum="1" >

	76

	77 <TextView

	78 android:id="@+id/password_entry_editor_name"

	79 android:textColor="@color/default_text_color"

	80 android:layout_width="fill_parent"

	81 android:layout_height="wrap_content"

	82 android:layout_marginTop="10dp"

	83 android:layout_marginStart="15dp"

	84 android:textAppearance="?android:attr/textAppearanceMedium"

	85 android:contentDescription="@string/password_entry_editor_copy_s tored_username" />

	86

	87 <View

	88 android:layout_width="0dp"

	89 android:layout_height="0dp"

	90 android:layout_weight="1" />

	91

	92 <ImageButton

	93 style="?android:attr/buttonStyleSmall"

	94 android:layout_width="match_parent"

	95 android:layout_height="wrap_content"

	96 android:layout_gravity="end"

	97 android:layout_marginTop="10dp"

	98 android:layout_marginEnd="15dp"

	99 android:src="@drawable/clipboard_black" />

	100

	101 </LinearLayout>

	102

	103 <TextView

	104 android:text="@string/password_entry_editor_password"

	105 android:textColor="@color/google_blue_700"

	106 android:layout_width="wrap_content"

	107 android:layout_height="wrap_content"

	108 android:layout_marginTop="5dp"

	109 android:layout_marginStart="15dp"

	110 android:gravity="center_vertical"

	111 android:textAppearance="?android:attr/textAppearanceMedium" />

	112

	113 <LinearLayout

	114 android:layout_width="wrap_content"

	115 android:layout_height="wrap_content"

	116 android:orientation="horizontal"

	117 android:weightSum="1" >

	118

	119 <TextView

	120 android:id="@+id/password_entry_editor_password"

	121 android:textColor="@color/default_text_color"

	122 android:layout_width="fill_parent"

	123 android:layout_height="wrap_content"

	124 android:layout_marginTop="10dp"

	125 android:layout_marginStart="15dp"

	126 android:textAppearance="?android:attr/textAppearanceMedium" />

	127

	128 <View

	129 android:layout_width="0dp"

	130 android:layout_height="0dp"

	131 android:layout_weight="1" />

	132

	133 <ImageButton

	134 style="?android:attr/buttonStyleSmall"

	135 android:layout_width="match_parent"

	136 android:layout_height="wrap_content"

	137 android:layout_gravity="end"

	138 android:layout_marginTop="10dp"

	139 android:layout_marginEnd="15dp"

	140 android:src="@drawable/eye_black"

	141 android:contentDescription="@string/password_entry_editor_view_s tored_password" />

	142

	143 <ImageButton

	144 style="?android:attr/buttonStyleSmall"

	145 android:layout_width="match_parent"

	146 android:layout_height="wrap_content"

	147 android:layout_gravity="end"

	148 android:layout_marginTop="10dp"

	149 android:layout_marginEnd="15dp"

	150 android:src="@drawable/clipboard_black"

	151 android:contentDescription="@string/password_entry_editor_copy_s tored_password" />

	152

	153 </LinearLayout>

	154

	155 </LinearLayout>

	156

	157 </ScrollView>

OLD	NEW