chrome/android/java/strings/android_chrome_strings.grd - Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add buttons Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index 296605437d0f4f4427c0ce0fd010167ba8e678a0..b918cff152dafdbed7703e53bacda9b251fa7908 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -331,7 +331,16 @@ CHAR-LIMIT guidelines:

Saved passwords will appear here.

</message>

- Edit saved name/password or exception

+ Edit saved account

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_LINK" desc='Title preceding link on password entry editor.'>

vabr (Chromium) 2016/07/18 16:00:26 This does not appear to be used?

dozsa 2016/07/18 18:44:52 It's used in the new UI, before displaying the lin

vabr (Chromium) 2016/07/19 08:44:38 Ah, that's the @string/password_entry_editor_link

+ Url

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_USERNAME" desc='Title preceding username on password entry editor.'>

+ Username

+ </message>

+ <message name="IDS_PASSWORD_ENTRY_EDITOR_PASSWORD" desc='Title preceding password on password entry editor.'>

+ Password

</message>