Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3980)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Issue 2156613002: Modify PasswordEntryEditor UI to display account credentials in a user-friendly manner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add buttons Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
index 3c32b088800bf1cfb58194150587884395e2656f..30ec736157eae036506a8e5634ffc9879622fce9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
@@ -9,7 +9,6 @@ import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
-import android.widget.Button;
import android.widget.TextView;
import org.chromium.chrome.R;
@@ -48,7 +47,8 @@ public class PasswordEntryEditor extends Fragment {
if (extras.containsKey(SavePasswordsPreferences.PASSWORD_LIST_NAME)) {
name = extras.getString(SavePasswordsPreferences.PASSWORD_LIST_NAME);
}
- TextView nameView = (TextView) v.findViewById(R.id.password_entry_editor_name);
+ TextView nameView =
+ (TextView) v.findViewById(R.id.password_entry_editor_name);
if (name != null) {
nameView.setText(name);
} else {
@@ -56,10 +56,9 @@ public class PasswordEntryEditor extends Fragment {
mException = true;
}
String url = extras.getString(SavePasswordsPreferences.PASSWORD_LIST_URL);
- TextView urlView = (TextView) v.findViewById(R.id.password_entry_editor_url);
+ TextView urlView =
+ (TextView) v.findViewById(R.id.password_entry_editor_url);
urlView.setText(url);
-
- hookupCancelDeleteButtons(v);
return v;
}
@@ -90,7 +89,7 @@ public class PasswordEntryEditor extends Fragment {
passwordUIView.updatePasswordLists();
}
- private void hookupCancelDeleteButtons(View v) {
+ /*private void hookupCancelDeleteButtons(View v) {
vabr (Chromium) 2016/07/18 16:00:26 Please make sure to deleted unused code before lan
dozsa 2016/07/18 18:44:52 Sorry, that's part of the previous view, I comment
final Button deleteButton = (Button) v.findViewById(R.id.password_entry_editor_delete);
final Button cancelButton = (Button) v.findViewById(R.id.password_entry_editor_cancel);
@@ -109,5 +108,5 @@ public class PasswordEntryEditor extends Fragment {
getActivity().finish();
}
});
- }
+ }*/
}

Powered by Google App Engine
This is Rietveld 408576698