Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5577)

Unified Diff: chrome/test/data/webui/settings/device_page_tests.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromeos tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/device_page_tests.js
diff --git a/chrome/test/data/webui/settings/device_page_tests.js b/chrome/test/data/webui/settings/device_page_tests.js
index 5ce176681f2f020682f61f5a3acd36fe878df782..66fe468f8d50369946cb412a8c22466468dc7e54 100644
--- a/chrome/test/data/webui/settings/device_page_tests.js
+++ b/chrome/test/data/webui/settings/device_page_tests.js
@@ -115,6 +115,11 @@ cr.define('device_page_tests', function() {
suiteSetup(function() {
// Disable animations so sub-pages open within one event loop.
testing.Test.disableAnimationsAndTransitions();
+
+ // Update the device page route for navigations.
+ settings.navigateTo = function(route) {
michaelpg 2016/07/20 19:48:23 Can you provide your own stub instead?
tommycli 2016/07/20 20:33:30 Per offline discussion, we are going to address th
+ devicePage.currentRoute = route;
+ };
});
setup(function(done) {
@@ -123,7 +128,7 @@ cr.define('device_page_tests', function() {
PolymerTest.clearBody();
devicePage = document.createElement('settings-device-page');
- devicePage.currentRoute = {page: 'basic', section: '', subpage: []};
+ devicePage.currentRoute = settings.Route.BASIC;
devicePage.prefs = fakePrefs;
settings.DevicePageBrowserProxyImpl.instance_ =
new TestDevicePageBrowserProxy();

Powered by Google App Engine
This is Rietveld 408576698